-
Notifications
You must be signed in to change notification settings - Fork 24.2k
Fixes bias not working when not qkv has diff size #66544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow For more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
❌ 11 New FailuresAs of commit 760c00c6c3 (more details on the Dr. CI page): Expand to see more
🕵️ 11 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Do you mind adding a test as well in test/test_nn.py
for the case of diff size qkv + bias?
sure thing, i'll try to add it this week~ |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
b53ea7b
to
a26839b
Compare
Hi @jbschlosser |
@ZhiyuanChen Haha no problem! Unfortunately, based on the CI checks, it does look like the test is failing |
could you please reopen this pr so that i can look into it? |
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sorry, something went wrong.
Fixes #{issue number}