8000 .github: Enable with-ssh for Windows by seemethere · Pull Request #63440 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

.github: Enable with-ssh for Windows #63440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

seemethere
Copy link
Member
@seemethere seemethere commented Aug 17, 2021

Stack from ghstack:

Signed-off-by: Eli Uriegas eliuriegas@fb.com

Differential Revision: D30521460

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
@pytorch-probot
Copy link
pytorch-probot bot commented Aug 17, 2021
CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/062535038c38cc2b421f879633000a9d5cfc4a4f/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-bionic-py3.8-gcc9-coverage ciflow/all, ciflow/coverage, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/win ✅ triggered
win-vs2019-cuda10.1-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/win ✅ triggered
Skipped Workflows
libtorch-linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
libtorch-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/win 🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands:
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Aug 17, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 0625350 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

seemethere added a commit that referenced this pull request Aug 17, 2021
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

ghstack-source-id: 8ada5f4
Pull Request resolved: #63440
@seemethere seemethere marked this pull request as draft August 17, 2021 23:08
@@ -121,6 +139,7 @@ jobs:
if-no-files-found: error
name: ${{ env.BUILD_ENVIRONMENT }}
path: C:\${{ github.run_id }}\build-results
!{{ wait_and_kill_ssh() }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an experiment with jinja2 macros, not entirely sure I like it since it makes it a bit harder to read but I guess they work 🤷🏽‍♂️

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
seemethere added a commit that referenced this pull request Aug 18, 2021
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

ghstack-source-id: 3df689a
Pull Request resolved: #63440

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@pytorch-probot pytorch-probot bot assigned pytorchbot and unassigned pytorchbot Aug 18, 2021
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
@pytorch-probot pytorch-probot bot assigned pytorchbot and unassigned pytorchbot Aug 24, 2021
seemethere added a commit that referenced this pull request Aug 24, 2021
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

ghstack-source-id: 959212f
Pull Request resolved: #63440

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
@pytorch-probot pytorch-probot bot assigned pytorchbot and unassigned pytorchbot Aug 24, 2021
seemethere added a commit that referenced this pull request Aug 24, 2021
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

ghstack-source-id: 8a02b98
Pull Request resolved: #63440

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere seemethere marked this pull request as ready for review August 24, 2021 19:36
@seemethere
Copy link
Member Author

@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@seemethere merged this pull request in 865d127.

@facebook-github-bot facebook-github-bot deleted the gh/seemethere/132/head branch August 28, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0