8000 std/var: Deprecate default `correction` value and `unbiased` argument by peterbell10 · Pull Request #55679 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

std/var: Deprecate default correction value and unbiased argument #55679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 57 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
58ac5d9
std/var: Deprecate default correction value
peterbell10 Apr 9, 2021
30d6401
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 13, 2021
558993a
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 15, 2021
64c6311
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 15, 2021
616fdf6
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 19, 2021
6917922
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 19, 2021
0b84a3b
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 19, 2021
e634721
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 20, 2021
8ad2a46
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 20, 2021
46f3956
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 21, 2021
37460b1
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 21, 2021
5b23cc9
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 22, 2021
27c30ed
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 23, 2021
b4427c7
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 27, 2021
de12904
Update on "std/var: Deprecate default correction value"
8000 peterbell10 Apr 29, 2021
5845b5c
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 29, 2021
c010d60
Update on "std/var: Deprecate default correction value"
peterbell10 May 4, 2021
b905ec4
Update on "std/var: Deprecate default correction value"
peterbell10 Jun 14, 2021
7eaa98f
Update on "std/var: Deprecate default correction value"
peterbell10 Jun 24, 2021
b1bcd66
Update on "std/var: Deprecate default correction value"
peterbell10 Jul 6, 2021
f931557
Update on "std/var: Deprecate default correction value"
peterbell10 Jul 7, 2021
58dbff1
Update on "std/var: Deprecate default correction value"
peterbell10 Jul 9, 2021
28b34e3
Update on "std/var: Deprecate default correction value"
peterbell10 Jul 9, 2021
87a60a6
Update on "std/var: Deprecate default correction value"
peterbell10 Aug 9, 2021
4fb2746
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 6, 2022
d4714c5
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 7, 2022
15a6441
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 12, 2022
f16eaeb
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 15, 2022
86d0e28
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 15, 2022
bcba142
Update on "std/var: Deprecate default correction value"
peterbell10 Apr 15, 2022
a9ed413
Update on "std/var: Deprecate default correction value"
peterbell10 Jul 30, 2022
888dcb3
Update on "std/var: Deprecate default correction value"
peterbell10 Jul 30, 2022
2ffe094
Rebase on "std/var: Deprecate default correction value"
peterbell10 Sep 28, 2022
28d522e
Update on "std/var: Deprecate default correction value"
peterbell10 Sep 28, 2022
2a43515
Update on "std/var: Deprecate default correction value"
peterbell10 Sep 29, 2022
b9cab95
Update on "std/var: Deprecate default correction value"
peterbell10 Sep 29, 2022
0793756
Add test for correction=None on "std/var: Deprecate default correctio…
peterbell10 Oct 3, 2022
7e69023
Update on "std/var: Deprecate default correction value"
peterbell10 Oct 4, 2022
404c53e
Update on "std/var: Deprecate default correction value"
peterbell10 Oct 13, 2022
61fafce
Update on "std/var: Deprecate default correction value"
peterbell10 Oct 15, 2022
cac16c6
Update on "std/var: Deprecate default `correction` value and `unbiase…
peterbell10 Oct 15, 2022
87266e0
Rebase and fix merge conflicts on "std/var: Deprecate default `correc…
peterbell10 Oct 16, 2022
a02bf2d
Update on "std/var: Deprecate default `correction` value and `unbiase…
peterbell10 Oct 16, 2022
e93ff6d
Update on "std/var: Deprecate default `correction` value and `unbiase…
peterbell10 Oct 17, 2022
11fc629
Update on "std/var: Deprecate default `correction` value and `unbiase…
peterbell10 Oct 17, 2022
638db4f
Update on "std/var: Deprecate default `correction` value and `unbiase…
peterbell10 Oct 19, 2022
211dc6d
Fix lint on "std/var: Deprecate default `correction` value and `unbia…
peterbell10 Oct 19, 2022
0b14c2c
Update on "std/var: Deprecate default `correction` value and `unbiase…
peterbell10 Oct 20, 2022
ad41bbb
Rebase and fix merge conflicts on "std/var: Deprecate default `correc…
peterbell10 Oct 21, 2022
ecbe7f5
Split std/var opinfos into two on "std/var: Deprecate default `correc…
peterbell10 Nov 1, 2022
9338b8c
Update on "std/var: Deprecate default `correction` value and `unbiase…
peterbell10 Nov 1, 2022
00473bd
Update on "std/var: Deprecate default `correction` value and `unbiase…
peterbell10 Nov 2, 2022
cfe3ffc
Update on "std/var: Deprecate default `correction` value and `unbiase…
peterbell10 Nov 2, 2022
dee08f2
Update on "std/var: Deprecate default `correction` value and `unbiase…
peterbell10 Nov 3, 2022
37d5873
Update on "std/var: Deprecate default `correction` value and `unbiase…
peterbell10 Nov 7, 2022
be40d20
Rebase on "std/var: Deprecate default `correction` value and `unbiase…
peterbell10 Dec 4, 2022
8b2bc01
Update on "std/var: Deprecate default `correction` value and `unbiase…
peterbell10 Dec 7, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update on "std/var: Deprecate default correction value"
[ghstack-poisoned]
  • Loading branch information
peterbell10 committed Apr 29, 2021
commit 5845b5c093cb14a78a2baf6b0ba491805629bc49
9 changes: 3 additions & 6 deletions aten/src/ATen/native/ReduceOps.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1308,12 +1308,9 @@ static std::tuple<Tensor&, Tensor&> std_var_mean_out(
fname, " only supports strided layout, got: ", self.layout());
TORCH_CHECK(at::isFloatingType(self.scalar_type()) || at::isComplexType(self.scalar_type()),
fname, " only support floating point and complex dtypes");
TORCH_CHECK(result1.scalar_type() == result2.scalar_type(),
"provided by result1 dtype must match dtype of result2. Got ",
toString(result1.scalar_type()),
" and ",
toString(result2.scalar_type()),
".");
TORCH_CHECK(result1.scalar_type() == c10::toValueType(result2.scalar_type()),
fname, " expected result1 to be real and match the precision of result2. Got ",
result1.scalar_type(), " and ", result2.scalar_type(), ".");
if (!correction_opt.has_value()) {
TORCH_WARN_ONCE(
fname, ": the default for the correction parameter is deprecated. ",
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.
0