8000 Updated linalg.lstsq with NumPy compatible kwarg rcond by IvanYashchuk · Pull Request #54723 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Updated linalg.lstsq with NumPy compatible kwarg rcond #54723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 22 commits into from
Closed

Updated linalg.lstsq with NumPy compatible kwarg rcond #54723

wants to merge 22 commits into from

Conversation

IvanYashchuk
Copy link
Collaborator
@IvanYashchuk IvanYashchuk commented Mar 25, 2021 •
edited by mruberry
Loading

Stack from ghstack:

Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

Differential Revision: D27993741

@IvanYashchuk
Updated linalg.lstsq with NumPy compatible kwarg rcond
977e767 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

[ghstack-poisoned]
This was referenced Mar 25, 2021
Closed
Closed
Closed
Closed
Closed
Closed
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Mar 25, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 843c2b1 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

1 failure not recognized by patterns:

Job Step Action
CircleCI binary_linux_libtorch_3_7m_cpu_devtoolset7_shared-with-deps_build Build 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@IvanYashchuk IvanYashchuk requested review from mruberry and removed request for albanD and soulitzer March 25, 2021 19:47
@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
b81b6c0 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

[ghstack-poisoned]
IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request Mar 29, 2021
@IvanYashchuk
Updated linalg.lstsq with NumPy compatible kwarg rcond
d945f11 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

ghstack-source-id: 80bd38f
Pull Request resolved: pytorch#54723
@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
8d92c4a 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

[ghstack-poisoned]
@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
9b94388 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

[ghstack-poisoned]
@IvanYashchuk IvanYashchuk requested a review from ezyang as a code owner March 29, 2021 15:00
@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
499d51d 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

[ghstack-poisoned]
@IvanYashchuk IvanYashchuk removed the request for review from ezyang March 29, 2021 15:19
@ezyang
Copy link
Contributor
ezyang commented Mar 29, 2021

ACKing native_functions.yaml change

@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
8314e44 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

[ghstack-poisoned]
IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request Mar 30, 2021
@IvanYashchuk
Updated linalg.lstsq with NumPy compatible kwarg rcond
5c8a38d 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

ghstack-source-id: dcc9ede
Pull Request resolved: pytorch#54723
@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
1da034e 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

[ghstack-poisoned]
@IvanYashchuk
Copy link
Collaborator Author

This PR is introducing backward-incompatible changes to aten::linalg_lstsq, but lstsq was merged only recently (on March 17). SciPy uses cond kwarg for specifying the tolerances while NumPy uses rcond, we should use rcond as well for NumPy compatibility.
I added aten::linalg_lstsq to allow_list in check_backward_compatibility.py with the end date in May.

In the future, I think a better name rtol should be added and promoted (Ref. #54151).

IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request Mar 30, 2021
@IvanYashchuk
Updated linalg.lstsq with NumPy compatible kwarg rcond
fb6be6a 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

ghstack-source-id: 2825aff
Pull Request resolved: pytorch#54723
@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
94bd964 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

[ghstack-poisoned]
IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request Apr 9, 2021
@IvanYashchuk
Updated linalg.lstsq with NumPy compatible kwarg rcond
e323c25 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

ghstack-source-id: 93681a4
Pull Request resolved: pytorch#54723
@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
e2bc32f 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

[ghstack-poisoned]
IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request Apr 13, 2021
@IvanYashchuk
Updated linalg.lstsq with NumPy compatible kwarg rcond
623a852 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

ghstack-source-id: 78e6155
Pull Request resolved: pytorch#54723
@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
19a99a2 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

[ghstack-poisoned]
IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request Apr 14, 2021
@IvanYashchuk
Updated linalg.lstsq with NumPy compatible kwarg rcond
42c73d4 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

ghstack-source-id: 4d3d618
Pull Request resolved: pytorch#54723
@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
349299e 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

[ghstack-poisoned]
@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
5100023 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

[ghstack-poisoned]
@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
648ba48 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

[ghstack-poisoned]
IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request Apr 20, 2021
@IvanYashchuk
Updated linalg.lstsq with NumPy compatible kwarg rcond
3681852 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

ghstack-source-id: 934b8f2
Pull Request resolved: pytorch#54723
10000 mruberry self-requested a review April 26, 2021 05:38
mruberry
mruberry approved these changes Apr 26, 2021
View reviewed changes
Copy link
Collaborator
@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice consistency improvement!

@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
b14ad54 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

Differential Revision: [D27993741](https://our.internmc.facebook.com/intern/diff/D27993741)

[ghstack-poisoned]
IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request Apr 26, 2021
@IvanYashchuk
Updated linalg.lstsq with NumPy compatible kwarg rcond
a289afa 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

ghstack-source-id: afbbe0c
Pull Request resolved: pytorch#54723
@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
78f9f97 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

Differential Revision: [D27993741](https://our.internmc.facebook.com/intern/diff/D27993741)

[ghstack-poisoned]
IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request Apr 27, 2021
@IvanYashchuk
Updated linalg.lstsq with NumPy compatible kwarg rcond
67e45df 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

ghstack-source-id: 1208544
Pull Request resolved: pytorch#54723
@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
84c10bd 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

Differential Revision: [D27993741](https://our.internmc.facebook.com/intern/diff/D27993741)

[ghstack-poisoned]
IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request Apr 28, 2021
@IvanYashchuk
Updated linalg.lstsq with NumPy compatible kwarg rcond
277aed0 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

ghstack-source-id: 7462958
Pull Request resolved: pytorch#54723
@IvanYashchuk
Update on "Updated linalg.lstsq with NumPy compatible kwarg rcond"
843c2b1 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

Differential Revision: [D27993741](https://our.internmc.facebook.com/intern/diff/D27993741)

[ghstack-poisoned]
IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request Apr 29, 2021
@IvanYashchuk
Updated linalg.lstsq with NumPy compatible kwarg rcond
9272b83 
Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

ghstack-source-id: ad0de75
Pull Request resolved: pytorch#54723
@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in 03962bc.

@facebook-github-bot facebook-github-bot deleted the gh/ivanyashchuk/5/head branch May 3, 2021 14:16
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
@IvanYashchuk
Updated linalg.lstsq with NumPy compatible kwarg rcond (pytorch#54723)
0b50d11 
Summary:
Pull Request resolved: pytorch#54723

Renamed "cond" -> "rcond" to be NumPy compatible. The default value for
rcond was changed to match non-legacy NumPy behavior.

Test Plan: Imported from OSS

Reviewed By: H-Huang

Differential Revision: D27993741

Pulled By: mruberry

fbshipit-source-id: a4baf25aca6a8272f1af2f963600866bfda56fb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry mruberry approved these changes

Assignees
No one assigned
Labels
cla signed Merged module: bc-breaking Related to a BC-breaking change open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IvanYashchuk @facebook-github-bot @ezyang @mruberry @pytorchbot
0