blas copy and axpy to aten #52345
blas copy and axpy to aten #52345
Conversation
💊 CI failures summary and remediationsAs of commit 747cb7d (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #52345 +/- ##
==========================================
- Coverage 80.79% 80.76% -0.04%
==========================================
Files 1972 1971 -1
Lines 216032 216093 +61
==========================================
- Hits 174539 174521 -18
- Misses 41493 41572 +79 |
50d5a77 to
c2032c0
Compare
There was a problem hiding this comment.
lgtm! just wondering if we should add the axpy and copy functions in /home/chourdiaanjali/pytorch/aten/src/ATen/native/sparse/... instead of /home/chourdiaanjali/pytorch/aten/src/ATen/native/cpu/.... @zou3519 what do you think?
axpy and copy are general functions that operate on CPU that can be used for non-sparse applications. It just so happens in our case that we use them to accelerate our sparse tensor APIs. Because they are general purpose BLAS APIs I think we should keep them in native/cpu/BlasKernel.cpp |
|
Thanks @ngimel for the feedback. I addressed the comments and fixed the errors found in logic. |
80a3d85 to
747cb7d
Compare
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary:
Fixes #{issue number}
Follow-up PR: pytorch#50984
`copy` and `axpy` functions are ported to ATen. `THBlas_axpy` and `THBlas_copy` are removed.
Looking forward your comments cc ngimel, mruberry
Pull Request resolved: pytorch#52345
Reviewed By: zou3519
Differential Revision: D26756533
Pulled By: ngimel
fbshipit-source-id: 97649485eeb6b361d6434c4701539b5abba4a17d
Summary:
Fixes #{issue number}
Follow-up PR: pytorch#50984
`copy` and `axpy` functions are ported to ATen. `THBlas_axpy` and `THBlas_copy` are removed.
Looking forward your comments cc ngimel, mruberry
Pull Request resolved: pytorch#52345
Reviewed By: zou3519
Differential Revision: D26756533
Pulled By: ngimel
fbshipit-source-id: 97649485eeb6b361d6434c4701539b5abba4a17d
Fixes #{issue number}
Follow-up PR: #50984
copyandaxpyfunctions are ported to ATen.THBlas_axpyandTHBlas_copyare removed.Looking forward your comments cc @ngimel, @mruberry