8000 Implement `np.diff` for single order differences by soulitzer · Pull Request #50569 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Implement np.diff for single order differences #50569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Implement np.diff for single order differences #50569

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5e99c87
Add implementation tests and docs
soulitzer Jan 15, 2021
1deba99
Fix typos and add message about method tests
soulitzer Jan 20, 2021
3afa2bc
Fix flake8
soulitzer Jan 20, 2021
84f28c4
Remove hacky wrapper, improve docs
soulitzer Jan 21, 2021
c948f1d
Update tensor docs
soulitzer Jan 21, 2021
abe47a0
Call .cpu() before .numpy()
soulitzer Jan 21, 2021
19bb4d4
Only handle tensor append and prepend
soulitzer Jan 25, 2021
ca2fc91
Merge branch 'master' of https://github.com/pytorch/pytorch into impl…
soulitzer Jan 25, 2021
1e99f18
Test for more dtypes, add comment
soulitzer Jan 25, 2021
c86c91a
typo
soulitzer Jan 25, 2021
49a17ad
Improve errors
soulitzer Jan 26, 2021
de86880
Address comments
soulitzer Jan 27, 2021
c301c8e
typo
soulitzer Jan 27, 2021
04d4936
All tensors are contiguous on XLA
soulitzer Jan 28, 2021
ad276dc
Merge branch 'master' of https://github.com/pytorch/pytorch into impl…
soulitzer Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typo
  • Loading branch information
@soulitzer
soulitzer committed Jan 25, 2021
commit c86c91abefb462d7eb03f83f00d051aede60c528
2 changes: 1 addition & 1 deletion aten/src/ATen/native/ReduceOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ Tensor cummaxmin_backward(const Tensor& grad, const Tensor& input, const Tensor&

static Tensor prepend_append_on_dim(const Tensor& self, const c10::optional<Tensor>& prepend, const c10::optional<Tensor>& append, int64_t dim) {
// Helper for diff that handles prepending and appending when at least one is present
TORCH_INTERNAL_ASSERT(prepend.has_value() || append.has_value(), "either prepend or append must be has_value");
TORCH_INTERNAL_ASSERT(prepend.has_value() || append.has_value(), "either prepend or append must be have value");
if (!prepend.has_value() && append.has_value()) {
return at::cat({self, append.value()}, dim);
} else if (prepend.has_value() && !append.has_value()) {
Expand Down
0