8000 [export] Improve error messages by angelayi · Pull Request #159881 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@angelayi
Copy link
8000
Contributor
@angelayi angelayi commented Aug 5, 2025

Originally, if the PT2 errored when loading, we would try to load using the old loader to fit BC issues. However this hides the error messages for if an up-to-date PT2 is erroring when loading due to some other reason.

@pytorch-bot
Copy link
pytorch-bot bot commented Aug 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159881

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 0e9a5d9 with merge base ee62177 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

@angelayi has imported this pull request. If you are a Meta employee, you can view this in D79655406.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 5, 2025
@iremyux
Copy link
Collaborator
iremyux commented Aug 5, 2025

Adding ciflow/win-arm64 label to trigger Windows Arm64 CI and its test purposes - nothing about this PR specifically. (It should not effect the acceptance of the PR even if it fails.)

@iremyux iremyux added the ciflow/win-arm64 Trigger Windows Arm64 CI Workflows label Aug 5, 2025
@angelayi
Copy link
Contributor Author
angelayi commented Aug 5, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the angelayi/save_error branch September 5, 2025 02:09
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
Originally, if the PT2 errored when loading, we would try to load using the old loader to fit BC issues. However this hides the error messages for if an up-to-date PT2 is erroring when loading due to some other reason.
Pull Request resolved: pytorch#159881
Approved by: https://github.com/yushangdi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/win-arm64 Trigger Windows Arm64 CI Workflows Merged release notes: export

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

0