8000 [C10] Add `Scalar::isUnsigned()` method by malfet · Pull Request #159877 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[C10] Add Scalar::isUnsigned() method #159877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[C10] Add Scalar::isUnsigned() method #159877

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7c9e37
Update
malfet Aug 5, 2025
d3b7598
Update
malfet Aug 5, 2025
ffc6fea
Update
malfet Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions c10/core/Scalar.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,17 @@ class C10_API Scalar {
isIntegral() const {
return Tag::HAS_i == tag || Tag::HAS_si == tag || Tag::HAS_u == tag;
}

bool isIntegral(bool includeBool) const {
return Tag::HAS_i == tag || Tag::HAS_si == tag || Tag::HAS_u == tag ||
(includeBool && isBoolean());
}

// See Note [Meaning of HAS_u]
bool isUnsigned() const {
return Tag::HAS_u == tag || (Tag::HAS_i == tag && v.i >= 0);
}
Copy link
Contributor
@ezyang ezyang Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is fine. But you might want an alternative that tells you if it fits in 64-bit int or not, since that's what you are probably actually interested in when you do the IValue.

Copy link
Contributor Author
@malfet malfet Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's kind of my debate: should I create some sort of semantically weird is64bitUnsigned API here, or check it on the caller side. I'm leaning towards later...


bool isComplex() const {
return Tag::HAS_z == tag;
}
Expand Down
Loading
0