8000 Fix perf downgrad by reverting template use in use_mkldnn_matmul by yanbing-j · Pull Request #159024 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@yanbing-j
Copy link
Collaborator
@yanbing-j yanbing-j commented Jul 24, 2025

This PR is to fix the performance downgrad by reverting template use in use_mkldnn_matmul in #157520 . Fix #159031 and #159551.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168

@pytorch-bot
Copy link
pytorch-bot bot commented Jul 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159024

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit eaf1dab with merge base 9a680e1 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ci-no-td Do not run TD on this PR module: cpu CPU specific problem (e.g., perf, algorithm) labels Jul 24, 2025
@yanbing-j yanbing-j added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Jul 24, 2025
@yanbing-j yanbing-j force-pushed the yanbing/fix_perf_of_use_mkldnn_matmul branch from ec5cf5a to 3e9cc06 Compare August 1, 2025 01:39
@yanbing-j yanbing-j marked this pull request as ready for review August 1, 2025 01:41
@yanbing-j yanbing-j requested a review from mingfeima August 1, 2025 01:41
@yanbing-j
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@yanbing-j
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased yanbing/fix_perf_of_use_mkldnn_matmul onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout yanbing/fix_perf_of_use_mkldnn_matmul && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the yanbing/fix_perf_of_use_mkldnn_matmul branch from 3e9cc06 to eaf1dab Compare August 4, 2025 01:05
@yanbing-j
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[inductor][cpu] AMP performance regression in 2025-07-21 nightly release

4 participants

0