8000 Add caching for `_rename_without_collisions` by hsjts0u · Pull Request #158594 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Add caching for _rename_without_collisions #158594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Add caching for _rename_without_collisions #158594

wants to merge 4 commits into from

Conversation

@hsjts0u
Copy link
Contributor
@hsjts0u hsjts0u commented Jul 17, 2025

Fixes #158357

@pytorch-bot
Copy link
pytorch-bot bot commented Jul 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158594

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 309f0dc with merge base ee09928 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link
linux-foundation-easycla bot commented Jul 17, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

pianpwk
pianpwk reviewed Jul 18, 2025
View reviewed changes
pianpwk
pianpwk reviewed Jul 18, 2025
View reviewed changes
@hsjts0u
Use a naive implementation
b19b210 
Rename the nodes so that anything that is renamed is strictly
increasing. This means gaps in suffixes are allowed.
@hsjts0u hsjts0u requested a review from pianpwk July 18, 2025 19:25
@hsjts0u
Copy link
Contributor Author
hsjts0u commented Jul 21, 2025

@pianpwk Can you take another look when you have time? Thanks

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jul 21, 2025

@pianpwk has imported this pull request. If you are a Meta employee, you can view this in D78697728.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 21, 2025
@hsjts0u
Copy link
Contributor Author
hsjts0u commented Jul 22, 2025

@pianpwk What else do I need to do to get this PR merged in?

@pianpwk
Copy link
Contributor
pianpwk commented Jul 22, 2025

@hsjts0u running the PR on internal tests looks good, I'll merge this internal-first. Nothing needed from your side right now.

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jul 22, 2025

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator
pytorchmergebot commented Jul 22, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pianpwk pianpwk pianpwk approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

@angelayi angelayi Awaiting requested review from angelayi angelayi is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: export

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Speed optimization for _rename_without_collisions in export

5 participants

@hsjts0u @facebook-github-bot @pianpwk @pytorchmergebot @pytorchbot
0