Add deprecation warning #158203
Closed
Add deprecation warning #158203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158203
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6630616 with merge base 4869f71 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78240836 |
ec8fbc1 to
45c71c7
Compare
45c71c7 to
30c236a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78240836 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78240836 |
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
Jul 13, 2025
Summary: Pull Request resolved: pytorch#158203 export_for_training exist because we couldn't migrate internal usages of export to the final IR. Now that we have completed the migration, we should deprecate and delete this API. Test Plan: CI Rollback Plan: Differential Revision: D78240836
30c236a to
f6da5c5
Compare
JacobSzwejbka
approved these changes
Jul 14, 2025
f6da5c5 to
b7c55fe
Compare
pytorch-bot bot
pushed a commit
that referenced
this pull request
Jul 20, 2025
Summary: export_for_training exist because we couldn't migrate internal usages of export to the final IR. Now that we have completed the migration, we should deprecate and delete this API. Test Plan: CI Rollback Plan: Reviewed By: JacobSzwejbka Differential Revision: D78240836
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
Jul 20, 2025
Summary: Pull Request resolved: pytorch#158203 export_for_training exist because we couldn't migrate internal usages of export to the final IR. Now that we have completed the migration, we should deprecate and delete this API. Test Plan: CI Rollback Plan: Reviewed By: JacobSzwejbka Differential Revision: D78240836
b7c55fe to
d5f4cd2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78240836 |
Summary: export_for_training exist because we couldn't migrate internal usages of export to the final IR. Now that we have completed the migration, we should deprecate and delete this API. Test Plan: CI Rollback Plan: Reviewed By: JacobSzwejbka Differential Revision: D78240836
d5f4cd2 to
6630616
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78240836 |
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: export_for_training exist because we couldn't migrate internal usages of export to the final IR. Now that we have completed the migration, we should deprecate and delete this API.
Test Plan:
CI
Rollback Plan:
Differential Revision: D78240836