[MPS] Add boilerplate sparse code support #157238
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157238
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 Cancelled Jobs, 3 Pending, 1 Unrelated FailureAs of commit b75c8aa with merge base 029e2b0 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
Attention! native_functions.yaml was changedIf you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info. Caused by: |
Attention! PyTorch one of the C-stable API file was changedYou MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function. Caused by: |
| SparseCUDA, | ||
| SparseCsrCPU, | ||
| SparseCsrCUDA, | ||
| SparseCsrMPS, |
There was a problem hiding this comment.
Do you really need CSR? May be let's just do regular Sparse, that would be sufficient for whisper
There was a problem hiding this comment.
Hmm, I'm wrong, let's keep it there...
There was a problem hiding this comment.
Just to clarify, whisper probably won't work with this PR only(haven't tested though), but this is a starter. More will follow, didn't want to submit one huge PR with all the necessary ops implemented
|
@pytorchbot merge -f "All relevant signal is green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This PR makes minimal changes to support sparse tensors on MPS. In the followup PRs I'll start adding different operations slowly so we can fix the issue of
#129842
which is highly requested(I assume because of whisper using sparse tensors)
cc @alexsamardzic @nikitaved @pearu @cpuhrsch @amjames @bhosmer @jcaip @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen