[binary builds] Linux aarch64 CUDA builds. Make sure tag is set correctly #154045
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154045
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Pending, 1 Unrelated FailureAs of commit d9b6aee with merge base 72a3c8d ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| "/usr/local/cuda/lib64/libcufile_rdma.so.1", | ||
| ] | ||
| elif "128" in desired_cuda: | ||
| if "128" in desired_cuda: |
There was a problem hiding this comment.
Those magic strings make me sad...
| @@ -55,9 +55,22 @@ def build_ArmComputeLibrary() -> None: | |||
| shutil.copytree(f"{acl_checkout_dir}/{d}", f"{acl_install_dir}/{d}") | |||
|
|
|||
|
|
|||
| def update_wheel(wheel_path, desired_cuda) -> None: | |||
| def replace_tag(filename) -> None: | |||
There was a problem hiding this comment.
Is there not a better way to set the tag directly?
There was a problem hiding this comment.
Yes with auditwheel, however there are some issues with it. Will be looking next on converting everything to auditwheel repair.
|
@pytorchmergebot merge -f "all required workflows are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot cherry-pick --onto release/2.7 -c critical |
…ctly (#154045) 1. This should set the Manylinux 2.28 tag correctly for CUDA Aarch builds. I believe we used to have something similar in the old script: https://github.com/pytorch/pytorch/blob/main/.ci/aarch64_linux/build_aarch64_wheel.py#L811 ``Tag: cp311-cp311-linux_aarch64 ``-> ``Tag: cp311-cp311-manylinux_2_28_aarch64`` 2. Remove section for CUDA 12.6, since we no longer building CUDA 12.6 aarch64 builds Pull Request resolved: #154045 Approved by: https://github.com/Camyll, https://github.com/malfet (cherry picked from commit 4277907)
Cherry picking #154045The cherry pick PR is at #154136 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
…ctly (#154136) [binary builds] Linux aarch64 CUDA builds. Make sure tag is set correctly (#154045) 1. This should set the Manylinux 2.28 tag correctly for CUDA Aarch builds. I believe we used to have something similar in the old script: https://github.com/pytorch/pytorch/blob/main/.ci/aarch64_linux/build_aarch64_wheel.py#L811 ``Tag: cp311-cp311-linux_aarch64 ``-> ``Tag: cp311-cp311-manylinux_2_28_aarch64`` 2. Remove section for CUDA 12.6, since we no longer building CUDA 12.6 aarch64 builds Pull Request resolved: #154045 Approved by: https://github.com/Camyll, https://github.com/malfet (cherry picked from commit 4277907) Co-authored-by: atalman <atalman@fb.com>
I believe we used to have something similar in the old script:
https://github.com/pytorch/pytorch/blob/main/.ci/aarch64_linux/build_aarch64_wheel.py#L811
Tag: cp311-cp311-linux_aarch64->Tag: cp311-cp311-manylinux_2_28_aarch64