8000 [Dynamo] Fix einops regression by mlazos · Pull Request #153925 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content
/ pytorch Public

[Dynamo] Fix einops regression #153925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Dynamo] Fix einops regression #153925

wants to merge 1 commit into from

Conversation

mlazos
Copy link
Contributor
@mlazos mlazos commented May 20, 2025 •
edited
Loading

Fixes #153476

test plan: This is covered by existing einops tests and I manually verified for the specific version of einops the user specified in the issue.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153925

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 51d95db with merge base 781ba0a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mlazos
Copy link
Contributor Author
mlazos commented May 20, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 20, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor
malfet commented May 21, 2025

@pytorchbot cherrypick --onto release/2.7 -c regression

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 21, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'cherrypick' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick', 'close')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@malfet
Copy link
Contributor
malfet commented May 21, 2025

@pytorchbot cherry-pick --onto release/2.7 -c regression

pytorchbot pushed a commit that referenced this pull request May 21, 2025
@mlazos @pytorchbot
[Dynamo] Fix einops regression (#153925)
87fad22 
Fixes #153476

Pull Request resolved: #153925
Approved by: https://github.com/williamwen42

(cherry picked from commit d44074f)
@pytorchbot
Copy link
Collaborator

Cherry picking #153925

The cherry pick PR is at #154053 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request May 21, 2025
Open
atalman pushed a commit that referenced this pull request May 22, 2025
@pytorchbot @mlazos
[Dynamo] Fix einops regression (#154053)
4c7314e 
[Dynamo] Fix einops regression (#153925)

Fixes #153476

Pull Request resolved: #153925
Approved by: https://github.com/williamwen42

(cherry picked from commit d44074f)

Co-authored-by: Michael Lazos <mlazos@meta.com>
@atalman atalman mentioned this pull request May 28, 2025
Open
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamwen42 williamwen42 williamwen42 approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo release notes: dynamo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] einops is unsupported and break dynamo graph with torch 2.7
5 participants
@mlazos @pytorchmergebot @malfet @pytorchbot @williamwen42
0