10000 Solve for tilings by eellison · Pull Request #153748 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Solve for tilings #153748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: gh/eellison/792/base
Choose a base branch
from
Open

Solve for tilings #153748

wants to merge 2 commits into from

Conversation

eellison
Copy link
Contributor
@eellison eellison commented May 16, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Find variables that coalesce the reads and writes and score the total size. If uncoalesced memory expressions are found, look for additional tiling of variables which will coalesce memory accesses.

For instance - for the following expression: (32*p0) // 2048, tiling p0 by 64 will make this expression coalesced.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

@eellison
Update
1f8a6a8 
[ghstack-poisoned]
@eellison eellison mentioned this pull request May 16, 2025
Open
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153748

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 12 New Failures, 1 Unrelated Failure

As of commit 6a53ed5 with merge base 5d316ce (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@eellison eellison mentioned this pull request May 16, 2025
Open
eellison added a commit that referenced this pull request May 16, 2025
@eellison
Solve for tilings
1e63ea0 
ghstack-source-id: 93734a1
Pull Request resolved: #153748
@eellison eellison added the topic: not user facing topic category label May 16, 2025
@eellison
Update
6a53ed5 
[ghstack-poisoned]
eellison added a commit that referenced this pull request May 16, 2025
@eellison
Solve for tilings
168250d 
ghstack-source-id: 93734a1
Pull Request resolved: #153748
@eellison eellison requested a review from jansel May 16, 2025 18:53
@eellison eellison mentioned this pull request May 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansel jansel Awaiting requested review from jansel

Assignees
No one assigned
Labels
ciflow/inductor module: inductor topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eellison
0