8000 Add missing arg descriptions for class RMSNorm(Module) by svekars · Pull Request #153738 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Add missing arg descriptions for class RMSNorm(Module) #153738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add missing arg descriptions for class RMSNorm(Module) #153738

wants to merge 6 commits into from

Conversation

svekars
Copy link
Contributor
@svekars svekars commented May 16, 2025 •
edited
Loading

Add missing arg descriptions for RMSNorm(Module)

cc @sekyondaMeta @AlannaBurke

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153738

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures

As of commit ec9bcbc with merge base 3aa8477 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars svekars requested a review from malfet May 16, 2025 16:39
@svekars svekars added module: docs Related to our documentation, both in docs/ and docblocks topic: docs topic category topic: not user facing topic category labels May 16, 2025
@svekars svekars changed the title Add a missing arg descriptions for RMSNorm(Module) Add missing arg descriptions for RMSNorm(Module) May 16, 2025
@svekars svekars changed the title Add missing arg descriptions for RMSNorm(Module) Add missing arg descriptions for class RMSNorm(Module) May 16, 2025
albanD
albanD approved these changes May 16, 2025
View reviewed changes
Copy link
Collaborator
@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good as-is.
As mentioned offline, many other Module have this issue so we could make it a shared docstring.

@svekars svekars force-pushed the add-missing-args-normalization branch from 595a19d to 217a806 Compare May 16, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@albanD albanD albanD approved these changes

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

Assignees
No one assigned
Labels
module: docs Related to our documentation, both in docs/ and docblocks topic: docs topic category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svekars @malfet @albanD
0