8000 [BE]: Improve typing in torch/modules/container.py by Skylion007 · Pull Request #153728 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[BE]: Improve typing in torch/modules/container.py #153728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[BE]: Improve typing in torch/modules/container.py #153728

wants to merge 1 commit into from

Conversation

Skylion007
Copy link
Collaborator
@Skylion007 Skylion007 commented May 16, 2025 •
edited
Loading

Adds some missing type annotations

cc @ezyang @malfet @xuzhao9 @gramster

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153728

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 16c4619 with merge base 8ca985b (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions GitHub Actions
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@Skylion007 Skylion007 added the module: typing Related to mypy type annotations label May 16, 2025
@Skylion007 Skylion007 requested review from malfet and atalman May 16, 2025 15:05
@Skylion007 Skylion007 force-pushed the skylion007/improve-typing-torch-container-2025-05-16 branch from ad9791f to 16c4619 Compare May 16, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet Awaiting requested review from malfet

@atalman atalman Awaiting requested review from atalman

@albanD albanD Awaiting requested review from albanD albanD will be requested when the pull request is marked ready for review albanD is a code owner

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser will be requested when the pull request is marked ready for review jbschlosser is a code owner

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki will be requested when the pull request is marked ready for review mikaylagawarecki is a code owner

Assignees
No one assigned
Labels
module: typing Related to mypy type annotations open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skylion007 @pytorchbot
0