10000 [XPU] [Windows] Auto turn on kineto XPU build when compiler version support. by xuhancn · Pull Request #153681 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[XPU] [Windows] Auto turn on kineto XPU build when compiler version support. #153681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign i 8000 n to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[XPU] [Windows] Auto turn on kineto XPU build when compiler version support. #153681

wants to merge 2 commits into from
+5 −1

Conversation

xuhancn
Copy link
Collaborator
@xuhancn xuhancn commented May 16, 2025 •
edited
Loading

Since SYCL compiler 20250101, it will remove dependency of level zero header. We can turn on kineto XPU by default.

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153681

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit e71a0eb with merge base 084c4aa (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@xuhancn xuhancn changed the title auto turn on kineto build when compiler version support. [XPU] [Windows] auto turn on kineto build when compiler version support. May 16, 2025
@xuhancn xuhancn changed the title [XPU] [Windows] auto turn on kineto build when compiler version support. [XPU] [Windows] auto turn on kineto XPU build when compiler version support. May 16, 2025
@xuhancn xuhancn changed the title [XPU] [Windows] auto turn on kineto XPU build when compiler version support. [XPU] [Windows] Auto turn on kineto XPU build when compiler version support. May 16, 2025
@xuhancn xuhancn added topic: not user facing topic category ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks labels May 16, 2025
@xuhancn xuhancn requested a review from chuanqi129 May 16, 2025 03:36
@xuhancn xuhancn marked this pull request as ready for review May 16, 2025 06:00
@xuhancn xuhancn requested a review from EikanWang May 16, 2025 06:17
@jerryzh168 jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 16, 2025
@EikanWang
Copy link
Collaborator

@pytorchbot rebase

@EikanWang EikanWang requested a review from Copilot May 17, 2025 01:48
Copilot
Copilot AI reviewed May 17, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • cmake/public/xpu.cmake: Language not supported

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased xu_auto_turn_on_kineto_xpu_build onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout xu_auto_turn_on_kineto_xpu_build && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the xu_auto_turn_on_kineto_xpu_build branch from da2d15f to e71a0eb Compare May 17, 2025 01:49
cyyever
cyyever approved these changes May 17, 2025
View reviewed changes
cmake/public/xpu.cmake
@@ -51,6 +51,10 @@ else()
set(XPU_ENABLE_KINETO FALSE)
endif()

if(NOT WIN32)
if(WIN32)
8000 if(${SYCL_COMPILER_VERSION} GREATER_EQUAL 20250101)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use VERSION_GREATER_EQUAL

@xuhancn
Copy link
Collaborator Author
xuhancn commented May 17, 2025

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • XPU (EikanWang, jgong5, gujinghui)
  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@chuanqi129 chuanqi129 chuanqi129 approved these changes

@cyyever cyyever cyyever approved these changes

@EikanWang EikanWang Awaiting requested review from EikanWang

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xuhancn @EikanWang @pytorchmergebot @chuanqi129 @cyyever @jerryzh168 @pytorchbot
0