8000 change guard_or impl for better perf and simplicity by laithsakka · Pull Request #153674 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

change guard_or impl for better perf and simplicity #153674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: gh/laithsakka/181/base
Choose a base branch
from
Open

change guard_or impl for better perf and simplicity #153674

wants to merge 1 commit into from

Conversation

laithsakka
Copy link
Contributor
@laithsakka laithsakka commented May 16, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

PR time benchmarks has been showing regressions as we move to guard_or_false, reason is that prev implementation do not cache.
This new approach will propagate the fallback value to eval and return it. allowing eval to cache and reducing scamming logs and complexity.

cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv

@laithsakka laithsakka requested a review from bobrenjc93 as a code owner May 16, 2025 00:46
@laithsakka laithsakka mentioned this pull request May 16, 2025
Open
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153674

Note: Links to docs will display an error until the docs builds have been completed.

❌ 13 New Failures, 2 Unrelated Failures

As of commit 91c8ec1 with merge base 8ac82a1 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor release notes: fx release notes category labels May 16, 2025
laithsakka added a commit that referenced this pull request May 16, 2025
@laithsakka
change guard_or impl for better perf and simplicity
657ff8d 
ghstack-source-id: 93d79de
Pull Request resolved: #153674
@laithsakka laithsakka requested a review from pianpwk May 16, 2025 00:47
bobrenjc93
bobrenjc93 reviewed May 16, 2025
View reviewed changes
test/test_dynamic_shapes.py
@@ -2848,7 +2848,7 @@ def func(a, b):
else:
return b * 20

# call with guarding.
# eager.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure how helpful this comment is, it seems self evident from the code?

bobrenjc93
bobrenjc93 requested changes May 16, 2025
View reviewed changes
Copy link
Contributor
@bobrenjc93 bobrenjc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks reasonable to me, back to you for test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobrenjc93 bobrenjc93 bobrenjc93 requested changes

@pianpwk pianpwk Awaiting requested review from pianpwk

Assignees
No one assigned
Labels
ciflow/inductor fx release notes: fx release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laithsakka @bobrenjc93 @facebook-github-bot
0