[Inductor] Construct subgraph with benchmarking args not example_inputs #153667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D74259569
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153667
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit d53847f with merge base 7e16cb9 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D74484747 |
0fb6441 to
2a36eba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74484747 |
2a36eba to
01f423c
Compare
…ts (pytorch#153667) Summary: Pull Request resolved: pytorch#153667 If the inputs to a subgraph has FlexibleLayout, the subgraph does not currently freeze the layouts here. Therefore, the `example_inputs` generated might not be consistent in layout with the `args` based in for benchmarking Test Plan: ` M, N, K = (4, 128, 14240) import torch torch.set_default_device("cuda") torch.compile(mode='max-autotune-no-cudagraphs') def foo(x, y): return (x + 1) @ y inps = [torch.rand([M, K], device='cuda', dtype=torch.bfloat16), torch.rand([K, N], device='cuda', dtype=torch.bfloat16)] foo(*inps) ` To produce FlexibleLayout with the stride change. Added to `test_subgraph_choice` Differential Revision: D74484747
|
This pull request was exported from Phabricator. Differential Revision: D74484747 |
01f423c to
d53847f
Compare
PaulZhang12
added a commit
to PaulZhang12/pytorch
that referenced
this pull request
May 16, 2025
…ts (pytorch#153667) Summary: If the inputs to a subgraph has FlexibleLayout, the subgraph does not currently freeze the layouts here. Therefore, the `example_inputs` generated might not be consistent in layout with the `args` based in for benchmarking Test Plan: ` M, N, K = (4, 128, 14240) import torch torch.set_default_device("cuda") torch.compile(mode='max-autotune-no-cudagraphs') def foo(x, y): return (x + 1) @ y inps = [torch.rand([M, K], device='cuda', dtype=torch.bfloat16), torch.rand([K, N], device='cuda', dtype=torch.bfloat16)] foo(*inps) ` To produce FlexibleLayout with the stride change. Added to `test_subgraph_choice` Differential Revision: D74900879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: If the inputs to a subgraph has FlexibleLayout, the subgraph does not currently freeze the layouts here. Therefore, the
example_inputsgenerated might not be consistent in layout with theargsbased in for benchmarkingTest Plan:
`
M, N, K = (4, 128, 14240)
import torch
torch.set_default_device("cuda")
torch.compile(mode='max-autotune-no-cudagraphs')
def foo(x, y):
return (x + 1) @ y
inps = [torch.rand([256, 256]) for _ in range(2)]
foo(*inps)
`
To produce FlexibleLayout. Also ran
test_max_autotune.pyDifferential Revision: D74484747
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov