[PyTorch][NCCL PG][Resubmit D67193887] Change getNCCLCommDumpMap to use new ncclCommDumpAll API #153636
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se new ncclCommDumpAll API Summary: see D67193887 Test Plan: https://www.internalfb.com/mlhub/pipelines/runs/mast/aps-dlrm_fsdp2_test-7711e496fc?job_attempt=0&version=0&tab=execution_details&env=PRODUCTION Differential Revision: D74820576
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153636
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit b3c444f with merge base 480ae2d ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D74820576 |
Skylion007
reviewed
May 15, 2025
Comment on lines
+394
to
+396
| std::stringstream ss; | ||
| ss << std::hex << ncclComm->getNcclUniqueHash(); | ||
| std::string ncclUniqueHashStr = ss.str(); |
There was a problem hiding this comment.
Suggested change
| std::stringstream ss; | |
| ss << std::hex << ncclComm->getNcclUniqueHash(); | |
| std::string ncclUniqueHashStr = ss.str(); | |
| std::string ncclUniqueHashStr = fmt::format("{:x}", ncclComm->getNcclUniqueHash()); |
More efficient and readable to use libfmt here?
Skylion007
reviewed
May 16, 2025
| ss << std::hex << ncclComm->getNcclUniqueHash(); | ||
| std::string ncclUniqueHashStr = ss.str(); | ||
|
|
||
| ncclDumpMap[ncclUniqueHashStr] = ncclComm->ncclCommDump(); |
There was a problem hiding this comment.
Suggested change
| ncclDumpMap[ncclUniqueHashStr] = ncclComm->ncclCommDump(); | |
| ncclDumpMap[std::move(ncclUniqueHashStr)] = ncclComm->ncclCommDump(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: see D67193887
Test Plan: https://www.internalfb.com/mlhub/pipelines/runs/mast/aps-dlrm_fsdp2_test-7711e496fc?job_attempt=0&version=0&tab=execution_details&env=PRODUCTION
Differential Revision: D74820576
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k