8000 Delete TorchScript based Android demo app and point to ExecuTorch by larryliu0820 · Pull Request #153633 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Delete TorchScript based Android demo app and point to ExecuTorch #153633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Delete TorchScript based Android demo app and point to ExecuTorch #153633

wants to merge 2 commits into from

Conversation

larryliu0820
Copy link
Contributor
@larryliu0820 larryliu0820 commented May 15, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Delete TorchScript demo app and point people to ExecuTorch demo app.

cc @albanD

@larryliu0820
Deprecate TorchScript based Android demo app and point to ExecuTorch
2ba1df7 
Summary:
As titled.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request May 15, 2025
@larryliu0820
Deprecate TorchScript based Android demo app and point to ExecuTorch
69a8e0f 
Summary:
As titled.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: c1d0b7d
Pull Request resolved: #153633
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153633

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 56 Pending

As of commit fc8803c with merge base 0cb4863 (image):
💚 Looks good so far! There are no failures yet. 💚

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@larryliu0820 larryliu0820 added topic: not user facing topic category suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) labels May 15, 2025
@larryliu0820
Copy link
Contributor Author

If you think that this rule should not apply to your PR,
please contact @albanD or @seemethere.

Can @albanD or @seemethere help unblock this PR?

@larryliu0820
Update on "Deprecate TorchScript based Android demo app and point to …
fc8803c 
…ExecuTorch"

Summary:
As titled.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request May 15, 2025
@larryliu0820
Deprecate TorchScript based Android demo app and point to ExecuTorch
98fe289 
Summary:
As titled.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 1fb6c49
Pull Request resolved: #153633
malfet
malfet approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted code is tested code

@larryliu0820 larryliu0820 requested review from seemethere and albanD May 15, 2025 18:40
janeyx99
janeyx99 approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor
@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!!

@seemethere
Copy link
Member

@pytorchbot merge -f 'deleted code is tested code'

@larryliu0820 larryliu0820 changed the title Deprecate TorchScript based Android demo app and point to ExecuTorch Delete TorchScript based Android demo app and point to ExecuTorch May 15, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@albanD
Copy link
Collaborator
albanD commented May 15, 2025

Skipping pr sanity check for removal is always ok!

@malfet
Copy link
Contributor
malfet commented May 15, 2025 •
edited
Loading

This broke our infra (see link), @seemethere when can we have refreshable infra for runners?

@malfet
Copy link
Contributor
malfet commented May 15, 2025

@pytorchbot revert -m "But libtorch build regressions are real, fbjni is still used for C++ builds" -c ignoredsignal

@malfet
Copy link
Contributor
malfet commented May 15, 2025

See https://github.com/pytorch/pytorch/actions/runs/15052773937/job/42311383050

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request May 15, 2025
@pytorchmergebot
Revert "Delete TorchScript based Android demo app and point to ExecuT…
ae0e8f0 
…orch (#153633)"

This reverts commit b22f01f.

Reverted #153633 on behalf of https://github.com/malfet due to But libtorch build regressions are real, fbjni is still used for C++ builds ([comment](#153633 (comment)))
@pytorchmergebot
Copy link
Collaborator

@larryliu0820 your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels May 15, 2025
larryliu0820 added a commit that referenced this pull request May 15, 2025
@larryliu0820
Reapply "Delete TorchScript based Android demo app and point to Execu…
e92171a 
…Torch (#153633)"

This reverts commit ae0e8f0.

Keep android/libs/fbjni because it's being used by other components of
PyTorch.

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request May 15, 2025
@larryliu0820
Reapply "Delete TorchScript based Android demo app and point to Execu…
9ff4059 
…Torch (#153633)"

This reverts commit ae0e8f0.

Keep android/libs/fbjni because it's being used by other components of
PyTorch.

ghstack-source-id: 7dc0f12
Pull Request resolved: #153656
@larryliu0820
Copy link
Contributor Author

Close in favor of #153656 (because I didn't know this PR will reopen after being reverted, so..)

larryliu0820 added a commit that referenced this pull request May 15, 2025
@larryliu0820
Update on "Reapply "Delete TorchScript based Android demo app and poi…
7509b02 
…nt to ExecuTorch (#153633)""

This reverts commit ae0e8f0.

Keep android/libs/fbjni because it's being used by other components of
PyTorch.

cc albanD

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request May 15, 2025
@larryliu0820
Reapply "Delete TorchScript based Android demo app and point to Execu…
79873b2 
…Torch (#153633)"

This reverts commit ae0e8f0.

Keep android/libs/fbjni because it's being used by other components of
PyTorch.

Remove `BUILD_JNI` option from CMakeLists.txt.

ghstack-source-id: 22001c8
Pull Request resolved: #153656
larryliu0820 added a commit that referenced this pull request May 15, 2025
@larryliu0820
Update base for Update on "Reapply "Delete TorchScript based Android …
f7aaeeb 
…demo app and point to ExecuTorch (#153633)""

This reverts commit ae0e8f0.

Keep android/libs/fbjni because it's being used by other components of
PyTorch.

cc albanD

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request May 15, 2025
@larryliu0820
Update on "Reapply "Delete TorchScript based Android demo app and poi…
b41653b 
…nt to ExecuTorch (#153633)""

This reverts commit ae0e8f0.

Keep android/libs/fbjni because it's being used by other components of
PyTorch.

cc albanD

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request May 15, 2025
@larryliu0820
Reapply "Delete TorchScript based Android demo app and point to Execu…
b73e433 
…Torch (#153633)"

This reverts commit ae0e8f0.

Keep android/libs/fbjni because it's being used by other components of
PyTorch.

Remove `BUILD_JNI` option from CMakeLists.txt.

ghstack-source-id: af2dc55
Pull Request resolved: #153656
pytorchmergebot pushed a commit that referenced this pull request May 16, 2025
@larryliu0820 @pytorchmergebot
Reapply "Delete TorchScript based Android demo app and point to Execu…
7ed377f 
…Torch (#153633)" (#153656)

This reverts commit ae0e8f0.

Keep android/libs/fbjni because it's being used by other components of
PyTorch.

Pull Request resolved: #153656
Approved by: https://github.com/malfet
pytorchmergebot added a commit that referenced this pull request May 16, 2025
@pytorchmergebot
Revert "Reapply "Delete TorchScript based Android demo app and point …
084c4aa 
…to ExecuTorch (#153633)" (#153656)"

This reverts commit 7ed377f.

Reverted #153656 on behalf of https://github.com/larryliu0820 due to Still being used internally so can't remove ([comment](#153656 (comment)))
@github-actions github-actions bot deleted the gh/larryliu0820/1/head branch June 19, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemethere seemethere seemethere approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@malfet malfet malfet approved these changes

@atalman atalman atalman approved these changes

@janeyx99 janeyx99 janeyx99 approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
ci-no-td Do not run TD on this PR Merged Reverted skip-pr-sanity-checks suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@larryliu0820 @seemethere @pytorchmergebot @albanD @malfet @Skylion007 @atalman @janeyx99
0