8000 [BE]: Remove redundant copy by Skylion007 · Pull Request #153629 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[BE]: Remove redundant copy #153629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[BE]: Remove redundant copy #153629

wants to merge 3 commits into from
+15 −9

Conversation

Skylion007
Copy link
Collaborator

Add typing and remove redundant copy

@Skylion007 Skylion007 requested a review from malfet May 15, 2025 16:18
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153629

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures

As of commit 591ab01 with merge base 4f4ecc5 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Skylion007 Skylion007 added the topic: not user facing topic category label May 15, 2025
@Skylion007 Skylion007 requested review from ezyang and atalman May 16, 2025 13:34
@Skylion007 Skylion007 added the better-engineering Relatively self-contained tasks for better engineering contributors label May 16, 2025
albanD
albanD approved these changes May 16, 2025
View reviewed changes
Copy link
Collaborator
@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public API test needs appeasing with a __all__ and sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@cyyever cyyever cyyever approved these changes

@malfet malfet Awaiting requested review from malfet

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

@ezyang ezyang Awaiting requested review from ezyang

@atalman atalman Awaiting requested review from atalman

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Skylion007 @albanD @cyyever @pytorchbot
0