8000 [BE]: Update ruff linter to 0.11.10 by Skylion007 · Pull Request #153625 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[BE]: Update ruff linter to 0.11.10 #153625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[BE]: Update ruff linter to 0.11.10 #153625

wants to merge 1 commit into from

Conversation

Skylion007
Copy link
Collaborator

Fixes a bug with #153543 where I forgot to add pyproject.toml to the list of files RUF can scan and also updates it to the latest version (which is just minor bugfixes).

@Skylion007 Skylion007 requested a review from malfet May 15, 2025 15:09
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153625

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures

As of commit 33546f4 with merge base 4f4ecc5 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 15, 2025
@Skylion007 Skylion007 changed the title [BE]: Update ruff linter to 0-11-10 [BE]: Update ruff linter to 0.11.10 May 15, 2025
@Skylion007 Skylion007 added the better-engineering Relatively self-contained tasks for better engineering contributors label May 15, 2025
@cyyever
Copy link
Collaborator
cyyever commented May 16, 2025 •
edited
Loading

Nice but should you apply ruff fix to fix possible issues?

@Skylion007
Copy link
Collaborator Author

Nice but should you apply ruff fix to fix possible issues?

No new issues, it's a minor version update

@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 16, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Collaborator
cyyever commented May 17, 2025

@pytorchbot merge -f "Unrelated CUDA failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

@cyyever cyyever cyyever approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Skylion007 @cyyever @pytorchmergebot @atalman @pytorchbot
0