fix a compilation issue when TORCH_XPU_ARCH_LIST is an empty string #153604

jingxu10 · 2025-05-15T09:11:51Z

When XPU_ARCH_FLAGS is an empty string, compilation will fail on C10_STRINGIZE(XPU_ARCH_FLAGS) in file torch/csrc/xpu/Module.cpp on Windows.
This PR fixes this issue by setting TORCH_XPU_ARCH_LIST to "" to avoid an empty string conversion in C10_STRINGIZE() when compiling without an AOT.

pytorch-bot · 2025-05-15T09:11:55Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153604

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit fe6bfc8 with merge base 8c16d0e ():

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / linux-jammy-py3-clang12-executorch / build (gh) (#150261)
Final attempt failed. Child_process exited with error code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jingxu10 · 2025-05-15T22:23:11Z

torch/CMakeLists.txt

@@ -431,6 +431,9 @@ endif()
 # Preserve XPU arch flags
 if(USE_XPU)
  string(REPLACE "," " " _ARCH_FLAGS_readable "${TORCH_XPU_ARCH_LIST}")
+  if("${TORCH_XPU_ARCH_LIST}" STREQUAL "")
+    set(_ARCH_FLAGS_readable "\\\"\\\"")


@@ -19,7 +19,7 @@ static PyObject* THXPModule_getArchFlags(PyObject* self, PyObject* noargs) {
  HANDLE_TH_ERRORS
 #ifdef XPU_ARCH_FLAGS
  static const char* flags = C10_STRINGIZE(XPU_ARCH_FLAGS);
-  return THPUtils_packString(flags);
+  return THPUtils_packString(strcmp(flags, "\"\"") == 0 ? "" : flags);


Change the empty string to "" to avoid string conversion failure in C10_STRINGIZE function.

I think a better way is to promote C10_STRINGIZE to support the empty string "", like

#define C10_STRINGIZE_IMPL(...) #__VA_ARGS__ #define C10_STRINGIZE(...) C10_STRINGIZE_IMPL(__VA_ARGS__)

I tried. It doesn't work. Still have the parsing issue.

Set the value back from "" to an empty string to avoid torch._C._xpu_getArchFlags() function returns "" as the arch flag.

Copilot

Pull Request Overview

This PR fixes a compilation issue on Windows when compiling without an AOT by ensuring that an empty XPU_ARCH_FLAGS value is handled correctly.

Replace the direct return of THPUtils_packString(flags) with a conditional check on flags.
Updates the behavior in torch/csrc/xpu/Module.cpp to avoid passing an empty string literal to C10_STRINGIZE.

Files not reviewed (1)

torch/CMakeLists.txt: Language not supported

Copilot · 2025-05-15T23:49:26Z

torch/csrc/xpu/Module.cpp

@@ -19,7 +19,7 @@ static PyObject* THXPModule_getArchFlags(PyObject* self, PyObject* noargs) {
  HANDLE_TH_ERRORS
 #ifdef XPU_ARCH_FLAGS
  static const char* flags = C10_STRINGIZE(XPU_ARCH_FLAGS);
-  return THPUtils_packString(flags);
+  return THPUtils_packString(strcmp(flags, "\"\"") == 0 ? "" : flags);


[nitpick] The conditional check compares 'flags' to a hard-coded magic literal """". Consider defining a named constant or adding a comment to clarify why the comparison is needed for handling empty flags.

Suggested change

return THPUtils_packString(strcmp(flags, "\"\"") == 0 ? "" : flags);

static const char* EMPTY_FLAGS = "\"\""; // Represents an empty flags string

return THPUtils_packString(strcmp(flags, EMPTY_FLAGS) == 0 ? "" : flags);

EikanWang · 2025-05-16T01:51:07Z

When will XPU_ARCH_FLAGS be an empty string?

jingxu10 · 2025-05-16T03:27:26Z

When will XPU_ARCH_FLAGS be an empty string?

When people don't want to perform compilation for device.

torch/csrc/xpu/Module.cpp

guangyey · 2025-05-23T08:00:01Z

torch/csrc/xpu/Module.cpp

+  // Since C10_STRINGIZE doesn't handle an empty string as its input correctly,
+  // the string "\"\"" will be passed from cmake to indicate an empty string.
+  static const char* EMPTY_FLAGS = "\"\"";
+  return THPUtils_packString(std::strcmp(flags, EMPTY_FLAGS) == 0 ? "" : flags);


Suggested change

return THPUtils_packString(std::strcmp(flags, EMPTY_FLAGS) == 0 ? "" : flags);

static const std::string flags = std::string(C10_STRINGIZE(XPU_ARCH_FLAGS));

return THPUtils_packString(flags);

Let's work around this issue using std::string constructor.

torch/csrc/xpu/Module.cpp

guangyey · 2025-05-26T09:49:43Z

@pytorchbot rebase

pytorchmergebot · 2025-05-26T09:51:33Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>

Co-authored-by: Yu, Guangye <106960996+guangyey@users.noreply.github.com>

pytorchmergebot · 2025-05-26T09:51:36Z

Successfully rebased jingxu10/null_xpu_aot_main onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout jingxu10/null_xpu_aot_main && git pull --rebase)

guangyey · 2025-05-27T02:51:08Z

@pytorchbot merge

pytorchmergebot · 2025-05-27T02:53:35Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

jingxu10 requested a review from guangyey May 15, 2025 09:11

pytorch-bot bot added the topic: not user facing topic category label May 15, 2025

pytorchbot added the open source label May 15, 2025

jingxu10 marked this pull request as draft May 15, 2025 09:42

jingxu10 force-pushed the jingxu10/null_xpu_aot_main branch from 6051cae to 3e2a85c Compare May 15, 2025 22:19

jingxu10 marked this pull request as ready for review May 15, 2025 22:20

jingxu10 requested review from EikanWang and gujinghui as code owners May 15, 2025 22:20

jingxu10 commented May 15, 2025

View reviewed changes

etaf requested a review from Copilot May 15, 2025 23:49

Copilot AI reviewed May 15, 2025

View reviewed changes

etaf added the ciflow/xpu Run XPU CI tasks label May 15, 2025

jingxu10 force-pushed the jingxu10/null_xpu_aot_main branch from 77b0c18 to 4058202 Compare May 16, 2025 03:32

jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 16, 2025

Skylion007 reviewed May 20, 2025

View reviewed changes

torch/csrc/xpu/Module.cpp Outdated Show resolved Hide resolved

jingxu10 marked this pull request as draft May 20, 2025 21:30

jingxu10 marked this pull request as ready for review May 22, 2025 07:55

guangyey reviewed May 23, 2025

View reviewed changes

guangyey added this to PyTorch Intel May 23, 2025

jingxu10 marked this pull request as draft May 23, 2025 09:14

jingxu10 force-pushed the jingxu10/null_xpu_aot_main branch from 696d4b4 to def8263 Compare May 23, 2025 12:28

guangyey approved these changes May 23, 2025

View reviewed changes

jingxu10 force-pushed the jingxu10/null_xpu_aot_main branch from def8263 to 4cb0843 Compare May 23, 2025 21:20

guangyey reviewed May 25, 2025

View reviewed changes

torch/csrc/xpu/Module.cpp Outdated Show resolved Hide resolved

guangyey reviewed May 26, 2025

View reviewed changes

torch/csrc/xpu/Module.cpp Outdated Show resolved Hide resolved

jingxu10 and others added 5 commits May 26, 2025 09:51

fix a compilation issue when TORCH_XPU_ARCH_LIST is an empty string

1dd6234

Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>

replace the C10_STRINGIZE with std::string constructor to fix the issue

074986e

Update torch/csrc/xpu/Module.cpp

39c2bd7

Co-authored-by: Yu, Guangye <106960996+guangyey@users.noreply.github.com>

remove constexpr from xpu Module.cpp

96b7baf

Update torch/csrc/xpu/Module.cpp

fe6bfc8

pytorchmergebot force-pushed the jingxu10/null_xpu_aot_main branch from d47fa27 to fe6bfc8 Compare May 26, 2025 09:51

guangyey approved these changes May 26, 2025

View reviewed changes

guangyey moved this to Review Required in PyTorch Intel May 26, 2025

guangyey marked this pull request as ready for review May 26, 2025 09:53

EikanWang approved these changes May 27, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 27, 2025

guangyey moved this from Review Required to Approved in PyTorch Intel May 27, 2025

pytorchmergebot added the merging label May 27, 2025

pytorchmergebot added the Merged label May 27, 2025

pytorchmergebot closed this in 8d89cdc May 27, 2025

github-project-automation bot moved this from Approved to Done in PyTorch Intel May 27, 2025

pytorchmergebot removed the merging label May 27, 2025

jingxu10 deleted the jingxu10/null_xpu_aot_main branch May 27, 2025 05:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix a compilation issue when TORCH_XPU_ARCH_LIST is an empty string #153604

fix a compilation issue when TORCH_XPU_ARCH_LIST is an empty string #153604

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

	return THPUtils_packString(strcmp(flags, "\"\"") == 0 ? "" : flags);
	static const char* EMPTY_FLAGS = "\"\""; // Represents an empty flags string
	return THPUtils_packString(strcmp(flags, EMPTY_FLAGS) == 0 ? "" : flags);

	return THPUtils_packString(std::strcmp(flags, EMPTY_FLAGS) == 0 ? "" : flags);
	static const std::string flags = std::string(C10_STRINGIZE(XPU_ARCH_FLAGS));
	return THPUtils_packString(flags);

fix a compilation issue when TORCH_XPU_ARCH_LIST is an empty string #153604

fix a compilation issue when TORCH_XPU_ARCH_LIST is an empty string #153604

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153604

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Merge started

Uh oh!

Uh oh!