[PT2][Optimus][Observability] Refactor the logging to avoid excessive tlparse log #153584
+87
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153584
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 15abb63 with merge base 76f182f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D74776025 |
6b35472 to
ddaad4b
Compare
mengluy0125
added a commit
to mengluy0125/pytorch
that referenced
this pull request
May 15, 2025
… tlparse log (pytorch#153584) Summary: context: https://fb.workplace.com/groups/943185660584207/permalink/1215335930035844/ Test Plan: before: aps-aps-ig_v4_2t_2_make_baseline_30batch-735703723-f735706162 tlparse: https://manifold.edge.x2p.facebook.net/v0/read/tree/logs/aps-aps-ig_v4_2t_2_make_baseline_30batch-735703723-f735706162/attempt_0/version_0/rank_0/index.html?bucketName=tlparse_reports&apiKey=tlparse_reports-key&withPayload=1&timeoutMsec=10000&fbclid=IwZXh0bgNhZW0CMTEAAR575JfJZUtE7kQCqzIZVCYomv1q03JzuMFVok8qDA_FuGC8oZ6rhhb2EziSQA_aem_abITQJZQP45t51_r-J-cFw Differential Revision: D74776025
|
This pull request was exported from Phabricator. Differential Revision: D74776025 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D74776025 |
ddaad4b to
137d6e6
Compare
mengluy0125
added a commit
to mengluy0125/pytorch
that referenced
this pull request
May 15, 2025
… tlparse log (pytorch#153584) Summary: Pull Request resolved: pytorch#153584 context: https://fb.workplace.com/groups/943185660584207/permalink/1215335930035844/ Test Plan: ``` buck2 test 'fbcode//mode/o pt' fbcode//caffe2/test/dynamo:test_dynamo -- --run-disabled --regex test_structured_trace.py ``` before: aps-aps-ig_v4_2t_2_make_baseline_30batch-735703723-f735706162 tlparse: https://manifold.edge.x2p.facebook.net/v0/read/tree/logs/aps-aps-ig_v4_2t_2_make_baseline_30batch-735703723-f735706162/attempt_0/version_0/rank_0/index.html?bucketName=tlparse_reports&apiKey=tlparse_reports-key&withPayload=1&timeoutMsec=10000&fbclid=IwZXh0bgNhZW0CMTEAAR575JfJZUtE7kQCqzIZVCYomv1q03JzuMFVok8qDA_FuGC8oZ6rhhb2EziSQA_aem_abITQJZQP45t51_r-J-cFw Differential Revision: D74776025
137d6e6 to
66a49a3
Compare
mengluy0125
added a commit
to mengluy0125/pytorch
that referenced
this pull request
May 16, 2025
… tlparse log (pytorch#153584) Summary: context: https://fb.workplace.com/groups/943185660584207/permalink/1215335930035844/ Test Plan: ``` buck2 test 'fbcode//mode/opt' fbcode//caffe2/test/dynamo:test_dynamo -- --run-disabled --regex test_structured_trace.py ``` before: aps-aps-ig_v4_2t_2_make_baseline_30batch-735703723-f735706162 tlparse: https://manifold.edge.x2p.facebook.net/v0/read/tree/logs/aps-aps-ig_v4_2t_2_make_baseline_30batch-735703723-f735706162/attempt_0/version_0/rank_0/index.html?bucketName=tlparse_reports&apiKey=tlparse_reports-key&withPayload=1&timeoutMsec=10000&fbclid=IwZXh0bgNhZW0CMTEAAR575JfJZUtE7kQCqzIZVCYomv1q03JzuMFVok8qDA_FuGC8oZ6rhhb2EziSQA_aem_abITQJZQP45t51_r-J-cFw Differential Revision: D74776025
|
This pull request was exported from Phabricator. Differential Revision: D74776025 |
… tlparse log (pytorch#153584) Summary: context: https://fb.workplace.com/groups/9431856605 A1C2 84207/permalink/1215335930035844/ Test Plan: ``` buck2 test 'fbcode//mode/opt' fbcode//caffe2/test/dynamo:test_dynamo -- --run-disabled --regex test_structured_trace.py ``` before: aps-aps-ig_v4_2t_2_make_baseline_30batch-735703723-f735706162 tlparse: https://manifold.edge.x2p.facebook.net/v0/read/tree/logs/aps-aps-ig_v4_2t_2_make_baseline_30batch-735703723-f735706162/attempt_0/version_0/rank_0/index.html?bucketName=tlparse_reports&apiKey=tlparse_reports-key&withPayload=1&timeoutMsec=10000&fbclid=IwZXh0bgNhZW0CMTEAAR575JfJZUtE7kQCqzIZVCYomv1q03JzuMFVok8qDA_FuGC8oZ6rhhb2EziSQA_aem_abITQJZQP45t51_r-J-cFw Differential Revision: D74776025
66a49a3 to
15abb63
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74776025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: context: https://fb.workplace.com/groups/943185660584207/permalink/1215335930035844/
Test Plan:
before: aps-aps-ig_v4_2t_2_make_baseline_30batch-735703723-f735706162
tlparse: https://manifold.edge.x2p.facebook.net/v0/read/tree/logs/aps-aps-ig_v4_2t_2_make_baseline_30batch-735703723-f735706162/attempt_0/version_0/rank_0/index.html?bucketName=tlparse_reports&apiKey=tlparse_reports-key&withPayload=1&timeoutMsec=10000&fbclid=IwZXh0bgNhZW0CMTEAAR575JfJZUtE7kQCqzIZVCYomv1q03JzuMFVok8qDA_FuGC8oZ6rhhb2EziSQA_aem_abITQJZQP45t51_r-J-cFw
Differential Revision: D74776025
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov