8000 [Torch][NT] Fix NestedTensor contiguous check condition. (#153237) by simonzgx · Pull Request #153529 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[Torch][NT] Fix NestedTensor contiguous check condition. (#153237) #153529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Torch][NT] Fix NestedTensor contiguous check condition. (#153237) #153529

wants to merge 1 commit into from

Conversation

simonzgx
Copy link
Contributor

Fixes #153237

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153529

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b9c0d36 with merge base 316c152 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link
linux-foundation-easycla bot commented May 14, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@simonzgx
Copy link
Contributor Author

@pytorchbot label "release notes: nested tensor"

@pytorch-bot pytorch-bot bot added the release notes: nested tensor Changes that have a direct impact on nested tensors label May 14, 2025
@simonzgx simonzgx changed the title [WIP][Torch] Fix NestedTensor contiguous check condition. (#153237) [Torch] Fix NestedTensor contiguous check condition. (#153237) May 14, 2025
@simonzgx simonzgx changed the title [Torch] Fix NestedTensor contiguous check condition. (#153237) [Torch][NT] Fix NestedTensor contiguous check condition. (#153237) May 14, 2025
jbschlosser
jbschlosser approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor
@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jbschlosser
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 14, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@mdeff mdeff mentioned this pull request May 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbschlosser jbschlosser jbschlosser approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: nested tensor Changes that have a direct impact on nested tensors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NJT] NestedTensor repr has contiguous=True while the NJT isn't contiguous
4 participants
@simonzgx @jbschlosser @pytorchmergebot @pytorchbot
0