Avoid calling fallback directly for symmetric memory tests #153520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153520
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit eff8f67 with merge base a13c8f2 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kwen2501
approved these changes
May 14, 2025
Comment on lines
+367
to
+370
| ag_output_vec = [] | ||
| mm_outputs_vec = [] | ||
| for context in test_contexts: | ||
| with context(): |
There was a problem hiding this comment.
nit: it seems a little bit obscure to wrap the test in a loop (and use vector).
Since there is only 1 special context here, how about:
ag_output_0, mm_outputs_0 = torch.ops.symm_mem.fused_all_gather_matmul(
A_shard, Bs, gather_dim=gather_dim, group_name=group.group_name
)
with _test_mode():
ag_output_1, mm_outputs_1 = torch.ops.symm_mem.fused_all_gather_matmul(
A_shard, Bs, gather_dim=gather_dim, group_name=group.group_name
)
assert torch.allclose(ag_output_0, ag_output_1)
There was a problem hiding this comment.
(Like you did for the other test below)
Sign up for free
to join this conversation on
6776
GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Since we can just use _test_mode to dispatch the calls, we should use this method to also verify the function signature is consistent.
cc @H-Huang @awgu @wanchaol @fduwjj @wz337 @wconstab @d4l3k