[nativert] port semaphore to c10 util #153504
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153504
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 94de1ce with merge base 480ae2d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 14, 2025
Summary: nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 14, 2025
Summary: Pull Request resolved: pytorch#153504 nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
11738a9 to
3f1bc9d
Compare
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 14, 2025
Summary: nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 14, 2025
Summary: Pull Request resolved: pytorch#153504 nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 14, 2025
Summary: nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 14, 2025
Summary: Pull Request resolved: pytorch#153504 nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
Skylion007
reviewed
May 14, 2025
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 14, 2025
Summary: nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 14, 2025
Summary: Pull Request resolved: pytorch#153504 nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 15, 2025
Summary: Pull Request resolved: pytorch#153504 nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 15, 2025
Summary: nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 15, 2025
Summary: Pull Request resolved: pytorch#153504 nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 15, 2025
Summary: nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 15, 2025
Summary: nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 15, 2025
Summary: Pull Request resolved: pytorch#153504 nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 15, 2025
Summary: nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
May 15, 2025
Summary: Pull Request resolved: pytorch#153504 nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
Summary: Pull Request resolved: pytorch#153504 nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed. This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore gonna need a oss build export to take a look at this... Test Plan: CI Differential Revision: D73882656
|
This pull request was exported from Phabricator. Differential Revision: D73882656 |
zhxchen17
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
nativert RFC: https://github.com/zhxchen17/rfcs/blob/master/RFC-0043-torch-native-runtime.md
To land the runtime into PyTorch core, we will gradually land logical parts of the code into the Github issue and get each piece properly reviewed.
This diff adds a simple semaphore interface into c10 until c++20 where we get counting_semaphore
gonna need a oss build export to take a look at this...
Test Plan: CI
Differential Revision: D73882656