8000 [dynamo] Add test to ensure we don't print fx graph upon data dependent graph break by StrongerXi · Pull Request #153416 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[dynamo] Add test to ensure we don't print fx graph upon data dependent graph break #153416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[dynamo] Add test to ensure we don't print fx graph upon data dependent graph break #153416

wants to merge 1 commit into from

Conversation

StrongerXi
Copy link
Contributor
@StrongerXi StrongerXi commented May 12, 2025 •
edited by pytorch-bot bot
Loading

@StrongerXi
[dynamo] Add test to ensure we don't print fx graph upon data depende…
f94bdd2 
…nt graph break

This adds a regression test for #149831, also as part of getting it
cherry-picked into 2.7.1.

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153416

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 4 Pending, 1 Unrelated Failure

As of commit f94bdd2 with merge base 0e59b59 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

StrongerXi added a commit that referenced this pull request May 12, 2025
@StrongerXi
[dynamo] Add test to ensure we don't print fx graph upon data depende…
a90d04a 
…nt graph break

This adds a regression test for #149831, also as part of getting it
cherry-picked into 2.7.1.

ghstack-source-id: fedc9ea
Pull Request resolved: #153416
@StrongerXi StrongerXi requested a review from atalman May 12, 2025 21:38
atalman
atalman approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor
@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@StrongerXi
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 13, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@StrongerXi
Copy link
Contributor Author

@pytorchbot merge -f "unrelated failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

StrongerXi added a commit that referenced this pull request May 13, 2025
@StrongerXi
[dynamo] Add test to ensure we don't print fx graph upon data depende…
b1bb73a 
…nt graph break

This adds a regression test for #149831, also as part of getting it
cherry-picked into 2.7.1.

ghstack-source-id: fedc9ea
Pull Request resolved: #153416
atalman pushed a commit that referenced this pull request May 14, 2025
@StrongerXi
Only print dde partial fx graph for export (#153218)
378a55c 
* Only print dde partial fx graph for export

Get #149831 into 2.7.1

* [dynamo] Add test to ensure we don't print fx graph upon data dependent graph break

This adds a regression test for #149831, also as part of getting it
cherry-picked into 2.7.1.

ghstack-source-id: fedc9ea
Pull Request resolved: #153416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StrongerXi @pytorchmergebot @atalman
0