-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Enable accelerator to perform streaming backward #153412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153412
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 83ed361 with merge base 18e13a6 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot revert -m "Need to revert in order to revert #151079" -c ghfirst |
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit d5d26ce. Reverted #153412 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert #151079 ([comment](#153412 (comment)))
@soulitzer your PR has been successfully reverted. |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes #153927 Although the autograd backward should always execute SideBw before MainBw, there is still a small chance the recorded events won't be in that order. Pull Request resolved: #153963 Approved by: https://github.com/janeyx99, https://github.com/Skylion007 ghstack dependencies: #151079, #153412
Stack from ghstack (oldest at bottom):
Also see #142097