8000 Enable accelerator to perform streaming backward by soulitzer · Pull Request #153412 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

Enable accelerator to perform streaming backward #153412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

soulitzer
Copy link
Contributor
@soulitzer soulitzer commented May 12, 2025

[ghstack-poisoned]
@soulitzer soulitzer requested a review from albanD as a code owner May 12, 2025 21:08
Copy link
pytorch-bot bot commented May 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153412

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 83ed361 with merge base 18e13a6 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

soulitzer added a commit that referenced this pull request May 12, 2025
ghstack-source-id: a0cc5f0
Pull-Request-resolved: #153412
8000 Copy link
Collaborator
@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@soulitzer soulitzer added the release notes: autograd release notes category label May 12, 2025
@pytorch pytorch deleted a comment from github-actions bot May 12, 2025
[ghstack-poisoned]
soulitzer added a commit that referenced this pull request May 12, 2025
ghstack-source-id: 9db82f9
Pull-Request-resolved: #153412
@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 12, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jeanschmidt
Copy link
Contributor

@pytorchbot revert -m "Need to revert in order to revert #151079" -c ghfirst

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

8000

pytorchmergebot added a commit that referenced this pull request May 14, 2025
This reverts commit d5d26ce.

Reverted #153412 on behalf of https://github.com/jeanschmidt due to Need to revert in order to revert #151079 ([comment](#153412 (comment)))
@pytorchmergebot
Copy link
Collaborator

@soulitzer your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels May 14, 2025
@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request May 20, 2025
Fixes #153927

Although the autograd backward should always execute SideBw before MainBw, there is still a small chance the recorded events won't be in that order.
Pull Request resolved: #153963
Approved by: https://github.com/janeyx99, https://github.com/Skylion007
ghstack dependencies: #151079, #153412
@github-actions github-actions bot deleted the gh/soulitzer/363/head branch June 19, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: autograd release notes category Reverted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0