8000 [DEBUG] REmove has CUDA by mzzchy · Pull Request #153349 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[DEBUG] REmove has CUDA #153349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[DEBUG] REmove has CUDA #153349

wants to merge 1 commit into from

Conversation

mzzchy
Copy link
Contributor
@mzzchy mzzchy commented May 11, 2025

Differential Revision: D74549863

@mzzchy @facebook-github-bot
[DEBUG] REmove has CUDA
ccf861f 
Differential Revision: D74549863
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153349

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit ccf861f with merge base 0104ac0 (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74549863

@github-actions GitHub Actions
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Skylion007
Skylion007 reviewed May 12, 2025
View reviewed changes
torch/csrc/profiler/python/combined_traceback.cpp
std::string line_s = "line";
std::string name_s = "name";
std::string filename_s = "filename";
std::vector<nlohmann::json> all_frames;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a reserve here to preallocate length

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@sraikund16 sraikund16 Awaiting requested review from sraikund16 sraikund16 is a code owner

@egienvalue egienvalue Awaiting requested review from egienvalue egienvalue is a code owner

Assignees
No one assigned
Labels
fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mzzchy @facebook-github-bot @Skylion007
0