8000 [Ez][BE]: Make implicit subpackage explicit by Skylion007 · Pull Request #153347 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[Ez][BE]: Make implicit subpackage explicit #153347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Ez][BE]: Make implicit subpackage explicit #153347

wants to merge 2 commits into from

Conversation

Skylion007
Copy link
Collaborator
@Skylion007 Skylion007 commented May 11, 2025 •
edited by pytorch-bot bot
Loading

While newer Python versions do support this, explicit namespace package helps more IDEs and other autocomplete features detect what are actually suppose to be modules a little bit easier.

cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153347

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Unrelated Failure

As of commit e1f0cc9 with merge base 01cbf5a (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label May 11, 2025
@Skylion007 Skylion007 requested review from malfet and albanD May 11, 2025 19:40
@Skylion007 Skylion007 added the better-engineering Relatively self-contained tasks for better engineering contributors label May 11, 2025
@Skylion007 Skylion007 requested review from ezyang and ngimel May 11, 2025 19:46
@Skylion007 Skylion007 changed the title [BE]: Make implicit subpackage explicit [Ez][BE]: Make implicit subpackage explicit May 11, 2025
albanD
albanD approved these changes May 12, 2025
View reviewed changes
Copy link
Collaborator
@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@Skylion007 Skylion007 mentioned this pull request May 14, 2025
Open
@shink shink mentioned this pull request May 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@albanD albanD albanD approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@ngimel ngimel Awaiting requested review from ngimel

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors fx open source release notes: fx release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Skylion007 @malfet @albanD @facebook-github-bot @pytorchbot
0