Adding view and reduction tags #153342
Open
Adding view and reduction tags #153342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153342
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 75477ec with merge base 909ec49 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
eellison
reviewed
May 15, 2025
| @@ -255,6 +256,122 @@ def test_multiple_devices(self, devices, dtype, op): | |||
| "Skipped! Only supports single tensor or iterable of tensor outputs." | |||
| ) | |||
|
|
|||
| def test_reduction_tag_coverage(self): | |||
There was a problem hiding this comment.
Looks great ! Would it be possible to add a test along the lines of https://github.com/pytorch/pytorch/pull/90029/files?show-viewed-files=true&file-filters%5B%5D=#diff-d183f2afc51d6a59bc70094e8f476d2468c45e415500f6eb60abad955e065156R155-R237? wdyt ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129020
Here's lists of the operator names annotated with view and reduction tags:
viewoverloads:as_strided, detach, view_as_real, view_as_complex, lift_fresh, diagonal, select, slice, transpose, split, t, expand, view, unsqueeze, unfold, squeeze, permute, unbind, split_with_sizes, alias
reductionoverloads:sum, mean, amin, amax, argmin, argmax, prod, all, norm, var, std, aminmax, nansum, logsumexp, any, std_mean, var_mean, count_nonzero, linalg_vector_norm, max, min