8000 [ca][dynamo] always run eager checkpoint region's recomputation in eager by xmfan · Pull Request #153300 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[ca][dynamo] always run eager checkpoint region's recomputation in eager #153300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

[ca][dynamo] always run eager checkpoint region's recomputation in eager #153300

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
75d9528
Update
xmfan May 10, 2025
aaa265b
Update
xmfan May 10, 2025
8ada3b1
Update
xmfan May 10, 2025
4a00c6c
Update
xmfan May 10, 2025
d2295a9
Update
xmfan May 10, 2025
4acedee
Update
xmfan May 10, 2025
4883d4f
Update
xmfan May 12, 2025
cbd73cb
Update
xmfan May 12, 2025
13b2f3d
Update
xmfan May 12, 2025
05f786d
Update
xmfan May 13, 2025
508e48b
Update
xmfan May 13, 2025
7786f21
Update
xmfan May 13, 2025
2cb3c35
Update
xmfan May 13, 2025
4c4139e
Update
xmfan May 13, 2025
bb64f3a
Update
xmfan May 14, 2025
a2844d7
Update
xmfan May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update 
[ghstack-poisoned]
  • Loading branch information
@xmfan
xmfan committed May 12, 2025
commit 13b2f3dca5fda9171c9b2cea09f7b5da58a2342c
4 changes: 2 additions & 2 deletions torch/utils/checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,8 +1107,6 @@ def pack_hook(x):
frame.x_metadatas.append(frame.metadata_fn(x))
return holder

# See Note: [compiled autograd and checkpoint unpack hook]
@torch._disable_dynamo
def unpack_hook(holder):
gid = torch._C._current_graph_task_id()
if gid == -1:
Expand Down Expand Up @@ -1494,6 +1492,8 @@ def _checkpoint_without_reentrant_generator(
had_device_in_fwd = True
fwd_devices, fwd_device_states = get_device_states(*args)

# See Note: [compiled autograd and checkpoint unpack hook]
@torch._disable_dynamo
def recompute_fn(*inputs):
kwargs, *args = inputs
# This will be called later during recomputation. This wrapping enables
Expand Down
Loading
0