-
Notifications
You must be signed in to change notification settings - Fork 24.8k
[WIP] add envvar to bisect number of graphs compiled #153275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c87ac36
[WIP] add envvar to bisect number of graphs compiled
eellison 15e8fb8
Update on "[WIP] add envvar to bisect number of graphs compiled"
eellison 6c692a7
Update on "[WIP] add envvar to bisect number of graphs compiled"
eellison 0b4390c
Update on "[WIP] add envvar to bisect number of graphs compiled"
eellison File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait for a second reviewer to agree on bikeshedding, but a few thoughts:
On having two configs: separate configs for "run the first X graphs through dynamo and fall the rest back to eager", vs. "of the graphs that go through dynamo, run the first Y through inductor and have the rest go through a simple backend" seems ok. I guess I'm not convinced that it's necessary, but having both knobs available for debugging seems useful
for the second config, at first I was surprised that you hardcoded the "fallback" backend to
aot_eager
, but if we're thinking about it as an extra option mainly to find bugs in inductor then it does sound relatively reasonable? We could have yet another config to specify the default backend but that feels like overkill. Alsoaot_eager_decomp_partition
seems to have a few cases where it does not give the same numerics as eager due to our decomps being bad, soaot_eager
if this backend is mainly for "debug inductor problems", wdyt of
debug_max_inductor_graphs
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdhirsh, sorry i reopened since this had internal cmomits. #154543
mind commenting there ?