Make python_agnostic cpp extension tests standalone #153274
Open
+65
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153274
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 18681a5 with merge base 916f6ba ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
janeyx99
reviewed
May 9, 2025
Related: #148920 This PR: * Introduces a new file `test/cpp_extensions/python_agnostic_extension/test/test_python_agnostic.py` with testing that follows the usual python testing patterns * This replaces the testing for python_agnostic in `test/test_cpp_extensions_aot.py` After this PR, it is now possible to run: ``` python test/cpp_extensions/python_agnostic_extension/test/test_python_agnostic.py ``` and the test will build the prerequisite wheel before running the tests. [ghstack-poisoned]
|
@pytorchmergebot merge -i |
cyyever
approved these changes
May 15, 2025
Merge startedYour change will be merged while ignoring the following 0 checks: Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / win-vs2022-cpu-py3 / test (default, 2, 3, lf.windows.4xlarge.nonephemeral) Details for Dev Infra teamRaised by workflow job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Related: #148920
This PR:
test/cpp_extensions/python_agnostic_extension/test/test_python_agnostic.pywith testing that follows the usual python testing patternstest/test_cpp_extensions_aot.pyAfter this PR, it is now possible to run:
and the test will build the prerequisite wheel before running the tests.