8000 [export] Move PT2 constants to torch::_export by angelayi · Pull Request #153206 · pytorch/pytorch · GitHub

[export] Move PT2 constants to torch::_export #153206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

angelayi wants to merge 1 commit into pytorch:main from angelayi:export-D74417085

Contributor

angelayi commented

•

Test Plan:
buck2 test //sigmoid/...
https://www.internalfb.com/intern/testinfra/testrun/1970325119807758

Differential Revision: D74417085

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

pytorch-bot bot commented

•

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153206

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

CUDA not found in NVIDIA runners

❌ 1 New Failure, 3 Unrelated Failures

As of commit a875368 with merge base f66a159 ():

NEW FAILURE - The following job has failed:

inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu) (gh)
distributed/test_dynamo_distributed.py::TestFakeDistributedSingleProc::test_hf_bert_ddp_aot_eager

FLAKY - The following job failed but was likely due to flakiness present on trunk:

linux-binary-manywheel / manywheel-py3_9-cuda12_8-test / test (gh) (similar failure)
RuntimeError: Found no NVIDIA driver on your system. Please check that you have an NVIDIA GPU and installed a driver from http://www.nvidia.com/Download/index.aspx

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

linux-binary-manywheel / manywheel-py3_9-cuda11_8-test / test (gh) (trunk failure)
RuntimeError: Found no NVIDIA driver on your system. Please check that you have an NVIDIA GPU and installed a driver from http://www.nvidia.com/Download/index.aspx
linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test (gh) (trunk failure)
RuntimeError: Found no NVIDIA driver on your system. Please check that you have an NVIDIA GPU and installed a driver from http://www.nvidia.com/Download/index.aspx

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added ciflow/inductor module: inductor labels

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D74417085

facebook-github-bot added the fb-exported label

angelayi added the topic: not user facing label

angelayi requested review from zhxchen17, yiming0416, dolpm and SherlockNoMad

May 8, 2025 23:22

zhxchen17 approved these changes

View reviewed changes

pytorch-bot bot added the ciflow/trunk label

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D74417085

angelayi force-pushed the export-D74417085 branch from 6ca72da to 599c119 Compare

May 12, 2025 23:45

pytorch-bot bot pushed a commit that referenced this pull request


          [export] Move PT2 constants to torch::_export (#153206)

599c119

Summary:
Pull Request resolved: #153206

before: `from sigmoid.core.package.pt2_archive_constants_pybind import ...`
after: `from torch._C._export.pt2_archive_constants import ...`
#buildall

Test Plan:
`buck2 test //sigmoid/...`
https://www.internalfb.com/intern/testinfra/testrun/1970325119807758

Differential Revision: D74417085

dolpm reviewed

View reviewed changes

torch/csrc/export/pt2_archive_constants.h Outdated Show resolved Hide resolved

torch/csrc/export/pt2_archive_constants.h Outdated Show resolved Hide resolved

8000

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D74417085

angelayi force-pushed the export-D74417085 branch from 599c119 to 4e5fcad Compare

May 15, 2025 20:57

angelayi requested review from avikchaudhuri, tugsbayasgalan and ydwu4 as code owners

May 15, 2025 20:57

angelayi added a commit to angelayi/pytorch that referenced this pull request


          [export] Move PT2 constants to torch::_export (pytorch#153206)

4e5fcad

Summary:
Pull Request resolved: pytorch#153206

before: `from sigmoid.core.package.pt2_archive_constants_pybind import ...`
after: `from torch._C._export.pt2_archive_constants import ...`
#buildall

Test Plan:
`buck2 test //sigmoid/...`
https://www.internalfb.com/intern/testinfra/testrun/1970325119807758

Reviewed By: zhxchen17

Differential Revision: D74417085

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D74417085

angelayi force-pushed the export-D74417085 branch from 4e5fcad to ace3bce Compare

May 16, 2025 06:22

angelayi added a commit to angelayi/pytorch that referenced this pull request


          [export] Move PT2 constants to torch::_export (pytorch#153206)

ace3bce

Summary:
Pull Request resolved: pytorch#153206

before: `from sigmoid.core.package.pt2_archive_constants_pybind import ...`
after: `from torch._C._export.pt2_archive_constants import ...`
#buildall

Test Plan:
`buck2 test //sigmoid/...`
https://www.internalfb.com/intern/testinfra/testrun/1970325119807758

Reviewed By: zhxchen17

Differential Revision: D74417085

dolpm approved these changes

View reviewed changes

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D74417085

angelayi force-pushed the export-D74417085 branch from ace3bce to f6bdcf8 Compare

May 16, 2025 14:40

angelayi added a commit to angelayi/pytorch that referenced this pull request


          [export] Move PT2 constants to torch::_export (pytorch#153206)

f6bdcf8

Summary:
Pull Request resolved: pytorch#153206

before: `from sigmoid.core.package.pt2_archive_constants_pybind import ...`
after: `from torch._C._export.pt2_archive_constants import ...`
#buildall

Test Plan:
`buck2 test //sigmoid/...`
https://www.internalfb.com/intern/testinfra/testrun/1970325119807758

Reviewed By: dolpm, zhxchen17

Differential Revision: D74417085


          [export] Move PT2 constants to torch::_export (pytorch#153206)

a875368

Summary:
Pull Request resolved: pytorch#153206

before: `from sigmoid.core.pa
8000
ckage.pt2_archive_constants_pybind import ...`
after: `from torch._C._export.pt2_archive_constants import ...`
#buildall

Test Plan:
`buck2 test //sigmoid/...`
https://www.internalfb.com/intern/testinfra/testrun/1970325119807758

Reviewed By: dolpm, zhxchen17

Differential Revision: D74417085

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D74417085

angelayi force-pushed the export-D74417085 branch from f6bdcf8 to a875368 Compare

May 16, 2025 14:47

Contributor

facebook-github-bot commented

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Collaborator

pytorchmergebot commented

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu)

Details for Dev Infra team

Raised by workflow job

pytorchmergebot removed the merging label

Contributor

jeanschmidt commented

@pytorchbot merge -f "merged internally via codev"

Collaborator

pytorchmergebot commented

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the merging label

pytorchmergebot closed this in

b4fb801

pytorchmergebot added Merged and removed merging labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zhxchen17 zhxchen17 approved these changes

dolpm dolpm approved these changes

yiming0416 Awaiting requested review from yiming0416

SherlockNoMad Awaiting requested review from SherlockNoMad

avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

Labels

ciflow/inductor ciflow/trunk fb-exported Merged module: inductor topic: not user facing

0