8000 [inductor] Fix #153071 by rec · Pull Request #153073 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[inductor] Fix #153071 #153073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: gh/rec/147/base
Choose a base branch
from
Open

[inductor] Fix #153071 #153073

wants to merge 2 commits into from

Conversation

rec
Copy link
Collaborator
@rec rec commented May 7, 2025

[ghstack-poisoned]
Copy link
pytorch-bot bot commented May 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153073

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 33361ca with merge base 47df195 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

rec added a commit that referenced this pull request May 7, 2025
ghstack-source-id: d44ed96
Pull Request resolved: #153073
@rec rec added the topic: not user facing topic category label May 7, 2025
Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is useful, as link is correct. We should probably stop the linter altogether

@rec
Copy link
Collaborator Author
rec commented May 7, 2025

Oh, no, I'll never get those 30 seconds back again. 😉

Yes, that's a very logical idea, why does it exist in the first place?

There are a whopping 3409 URLs in Python files under torch/ of which exactly 0 are marked with @lint-ignore. Is it really the case that the CI hits 3409 URLs all over the Internet on each run?

I'll look at that linter, I'm not yet familiar with it.

@rec rec closed this May 7, 2025
@rec rec reopened this May 7, 2025
@rec rec changed the title Fix #153071 [inductor] Fix #153071 May 7, 2025
@rec
Copy link
Collaborator Author
rec commented May 7, 2025

Hah, came to the same conclusion as you did, just a bit later.

It's nearly all checking URLs under our control except this, so I'm reopening this as the quickest fix.

[ghstack-poisoned]
rec added a commit that referenced this pull request May 12, 2025
ghstack-source-id: f7d819e
Pull Request resolved: #153073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0