[hop_schema] support gen_schema for invoke_subgraph #152984
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced May 6, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152984
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit bb83b5c with merge base 7a0781e ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zou3519
reviewed
May 13, 2025
Comment on lines
+80
to
+101
| def gen_schema(self, subgraph, identifier, *operands): | ||
| from torch._higher_order_ops.schema import HopSchemaGenerator | ||
| from torch._higher_order_ops.utils import ( | ||
| check_input_alias_and_mutation_return_ouputs, | ||
| ) | ||
|
|
||
| schema_gen = HopSchemaGenerator(self) | ||
| schema_gen.add_arg("subgraph", subgraph) | ||
| schema_gen.add_arg("identifier", identifier) | ||
| example_inputs = [ | ||
| n.meta["val"] if "val" in n.meta else n.meta["example_value"] | ||
| for n in subgraph.graph.find_nodes(op="placeholder") | ||
| ] | ||
| mutated_inputs, _, _, _, outputs = check_input_alias_and_mutation_return_ouputs( | ||
| subgraph, example_inputs | ||
| ) | ||
| for idx, arg in enumerate(operands): | ||
| schema_gen.add_arg(f"arg{idx}", arg, is_mutated=idx in mutated_inputs) | ||
| for out in outputs: | ||
| schema_gen.add_output(out) | ||
|
|
||
| return schema_gen.gen_schema() |
There was a problem hiding this comment.
ofc, this is your design lol
There was a problem hiding this comment.
Honestly I don't remember this at all so it is now your design :P
zou3519
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):