8000 [benchmarks] disable aten.to metadata assertions for AOTI by pianpwk · Pull Request #152915 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[benchmarks] disable aten.to metadata assertions for AOTI #152915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[benchmarks] disable aten.to metadata assertions for AOTI #152915

wants to merge 4 commits into from

Conversation

pianpwk
Copy link
Contributor
@pianpwk pianpwk commented May 6, 2025 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152915

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 23 Pending

As of commit 4499ee8 with merge base 1dd36ad (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pianpwk pianpwk changed the title Update common.py [benchmarks] disable aten.to metadata assertions for aoti May 6, 2025
@pianpwk pianpwk changed the title [benchmarks] disable aten.to metadata assertions for aoti [benchmarks] disable aten.to metadata assertions for AOTI May 6, 2025
@pianpwk pianpwk added the release notes: benchmark release notes category label May 6, 2025
@pianpwk
Copy link
Contributor Author
pianpwk commented May 6, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #152915, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@pianpwk pianpwk marked this pull request as ready for review May 6, 2025 07:03
8000
@pianpwk pianpwk mentioned this pull request May 6, 2025
Open
@pianpwk pianpwk requested a review from desertfire May 6, 2025 18:17
desertfire
desertfire reviewed May 6, 2025
View reviewed changes
Copy link
Contributor
@desertfire desertfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the underlying problem more properly? It's not urgent to fix #152606 and you can take your time.

@pianpwk pianpwk closed this May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertfire desertfire desertfire left review comments

Assignees
No one assigned
Labels
ciflow/inductor module: dynamo release notes: benchmark release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pianpwk @pytorchmergebot @desertfire
0