8000 Fix negative dim issue in for parallel loss context manager by abhilash1910 · Pull Request #152785 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Fix negative dim issue in for parallel loss context manager #152785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Fix negative dim issue in for parallel loss context manager #152785

wants to merge 5 commits into from

Conversation

abhilash1910
Copy link
Contributor
@abhilash1910 abhilash1910 commented May 4, 2025 •
edited by pytorch-bot bot
Loading

Facing similar issue as on #152016 , and added as per @tianyu-l 's solution.
Fixes #152016

Tagging @tianyu-l @atalman for review.

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152785

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 5e21e3e with merge base 032ef48 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link
linux-foundation-easycla bot commented May 4, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot pytorch-bot bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label May 4, 2025
@abhilash1910
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 5, 2025
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 6, 2025
@zou3519 zou3519 requested a review from tianyu-l May 6, 2025 12:31
tianyu-l
tianyu-l reviewed May 6, 2025
View reviewed changes
Copy link
Contributor
@tianyu-l tianyu-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some comments. Also could you please sign CLA?

@abhilash1910
Copy link
Contributor Author

Thanks @tianyu-l , I have signed the CLA already ; not sure why the authentication is missing.

tianyu-l
tianyu-l reviewed May 8, 2025
View reviewed changes
Copy link
Contributor
@tianyu-l tianyu-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh it says

❌ The email address for the commit (0677c61, 885a420) is not linked to the GitHub account, preventing the EasyCLA check.

Is it possible to fix? Thanks!

@abhilash1910
Copy link
Contributor Author

Thanks @tianyu-l CLA is fixed now.

@tianyu-l tianyu-l added the ciflow/trunk Trigger trunk jobs on your pull request label May 8, 2025
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 8, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label May 8, 2025
@tianyu-l tianyu-l added the ciflow/trunk Trigger trunk jobs on your pull request label May 8, 2025
@tianyu-l
Copy link
Contributor
tianyu-l commented May 8, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased loss_fix onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout loss_fix && git pull --rebase)

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label May 8, 2025
@abhilash1910
Copy link
Contributor Author

@tianyu-l could you help to trigger the CI pipelines ? Thanks

@tianyu-l
Copy link
Contributor

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased loss_fix onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout loss_fix && git pull --rebase)

@abhilash1910
Copy link
Contributor Author

Hi @zou3519 , @tianyu-l is there anything left to do on this PR ? Thanks.

@tianyu-l
Copy link
Contributor

@pytorchbot merge

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 14, 2025

This PR needs to be approved by an authorized maintainer before merge.

tianyu-l
tianyu-l approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor
@tianyu-l tianyu-l left a comment
6D40

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianyu-l
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 14, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyu-l tianyu-l tianyu-l approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loss parallel's override of log_softmax doesn't support negative dims
5 participants
@abhilash1910 @tianyu-l @pytorchmergebot @zou3519 @pytorchbot
0