[Inductor] Pattern matcher support for mutable ops with non-view inputs #152775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152775
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled Job, 1 Unrelated FailureAs of commit 69fd7e1 with merge base 56d6d4d ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
yf225
added a commit
that referenced
this pull request
May 4, 2025
…n-view inputs" Pull-Request-resolved: #152767 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
yf225
added a commit
that referenced
this pull request
May 4, 2025
…n-view inputs" Pull-Request-resolved: #152767 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
yf225
added a commit
that referenced
this pull request
May 4, 2025
…n-view inputs" Pull-Request-resolved: #152767 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
zou3519
reviewed
May 6, 2025
| @@ -2082,6 +2083,7 @@ def fwd_only( | |||
| fn: Callable[..., Any], | |||
| args: Sequence[Any], | |||
| *, | |||
| apply_auto_functionalize: bool = False, | |||
There was a problem hiding this comment.
@eellison usually has some ideas around API expansion.
There was a problem hiding this comment.
+1
apply_auto_functionalize: bool = False,
run_functional_passes: bool = True,
How do these two options relate to each other ? when would you do one but not the other ?
There was a problem hiding this comment.
discussed with Richard, currently:
run_functional_passes=Truemeans "run DCE on the pattern and replacement graphs" (which is not safe to use for reinplace pass), maybe we can rename it torun_dce_and_noop_elimination.apply_auto_functionalize=Truemeans "run functionalize on both pattern and replacement graphs", maybe we can rename it tofunctionalize_patterns.
Q: Can we merge the two flags?
Seems in general they are the same value:
- if "non_functional_ir", both False
- if "functional_ir", both True
- However pre_grad FX IR is an exception right now: it's "non_functional_ir", but it currently has
run_functional_passes=True; so we might need to change it to False, if we want to merge the two flags.
zou3519
reviewed
May 6, 2025
zou3519
reviewed
May 6, 2025
| search_fn=mutable_ops_pattern, | ||
| replace_fn=mutable_ops_replacement, | ||
| example_inputs=[inp.clone().detach(), inp.clone().detach()], | ||
| trace_fn=functools.partial(fwd_only, apply_auto_functionalize=True), |
There was a problem hiding this comment.
- Should apply_auto_functionalize be the default for fwd_only? Since Inductor pattern matching happens only at the post-grad pass?
- If not, should we rename
apply_auto_functionalizesomething likepost_grad? Because that is where we plan to use the pattern matcher
zou3519
reviewed
May 6, 2025
| register_replacement( | ||
| search_fn=mutable_ops_pattern, | ||
| replace_fn=mutable_ops_replacement, | ||
| example_inputs=[inp.clone().detach(), inp.clone().detach()], |
There was a problem hiding this comment.
We are technically exposing fwd_only as public API.
Instead of doing that I think it might be better for PatternMatcherPass to get an enum about the location it's operating on (e.g. post-grad functional IR).
zou3519
reviewed
May 6, 2025
zou3519
reviewed
May 6, 2025
Closed
yf225
added a commit
that referenced
this pull request
May 7, 2025
Closed
yf225
added a commit
that referenced
this pull request
May 7, 2025
yf225
added a commit
that referenced
this pull request
May 7, 2025
yf225
added a commit
that referenced
this pull request
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the non-view input use case in #152441.
Stack from ghstack (oldest at bottom):
Pull-Request-resolved: #152767
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov