8000 Fix evaluate_expr to include suppress_guards_tls in cache key by aorenste · Pull Request #152661 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Fix evaluate_expr to include suppress_guards_tls in cache key #152661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Fix evaluate_expr to include suppress_guards_tls in cache key #152661

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a1c6178
Fix evaluate_expr to include suppress_guards_tls in cache key
aorenste May 2, 2025
e2aa64b
Update on "Fix evaluate_expr to include suppress_guards_tls in cache …
aorenste May 2, 2025
eeafea7
Update on "Fix evaluate_expr to include suppress_guards_tls in cache …
aorenste May 2, 2025
f6fed2e
Update on "Fix evaluate_expr to include suppress_guards_tls in cache …
aorenste May 2, 2025
21eb212
Update on "Fix evaluate_expr to include suppress_guards_tls in cache …
aorenste May 2, 2025
decb05e
Update on "Fix evaluate_expr to include suppress_guards_tls in cache …
aorenste May 5, 2025
77f7f4d
Update on "Fix evaluate_expr to include suppress_guards_tls in cache …
aorenste May 7, 2025
File filter

Filter by extension

Filter by extension
8000
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update on "Fix evaluate_expr to include suppress_guards_tls in cache … 
…key"

ShapeEnv.evaluate_expr() behaves differently based on the (tls) global "suppress_guards" - so its cache key needs to include that value.

This came up because #152662 triggered it in the test `test/dynamo/test_exc.py::ExcTests::test_trigger_bisect_on_error` - fixing this caused that test to work again.




cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv

[ghstack-poisoned]
  • Loading branch information
@aorenste
aorenste committed May 5, 2025
commit decb05e4b71027249bb3028ec98f158b58a4a696
2 changes: 1 addition & 1 deletion benchmarks/dynamo/pr_time_benchmarks/expected_results.csv 854D
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ basic_modules_ListOfLinears_inductor_gpu,compile_time_instruction_count,97140000



update_hint_regression,compile_time_instruction_count,1608000000,0.02
update_hint_regression,compile_time_instruction_count,1652622314,0.02



Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.
0