Fix #152280: add Literal[…] PaddingMode to Conv modules #152590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Defines PaddingMode alias
* Annotates Conv{1,2,3}d constructors
* Fixes pytorch#152280
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152590
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 5ccdcc5 with merge base 5236a85 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The committers listed above are authorized under a signed CLA. |
Skylion007
reviewed
May 6, 2025
| @@ -79,7 +82,7 @@ def _conv_forward(self, input: Tensor, weight: Tensor, bias: Optional[Tensor]) - | |||
| transposed: bool | |||
| output_padding: tuple[int, ...] | |||
| groups: int | |||
| padding_mode: str | |||
| padding_mode: PaddingMode | |||
There was a problem hiding this comment.
Maybe the abstract base classes can still have str and only the leaf classes need PaddingMode for backwards compatibility
|
@AnandVishesh1301 Please fix the remaining type errors |
8000
|
@Skylion007 Sure, doing that now. Will create a PR soon. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
padding_modetype annotations in convolution modules to useLiteralfor improved type safety. This PR builds on #152458 by @sujeet4010, addressing unresolved MYPY errors intorch/ao/nn/qat/modules/conv.pyand adding test coverage.Related Issues
torch/nn/modules/conv.pyto use Literal for support padding modes #152280 (original issue)Changes Made
Literaltype to QAT modules.Credit to @sujeet4010 for the initial implementation.