Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152546
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
AlannaBurke
commented
Apr 30, 2025
CONTRIBUTING.md
Outdated
| @@ -111,6 +111,7 @@ source venv/bin/activate # or `& .\venv\Scripts\Activate.ps1` on Windows | |||
| you can always `uninstall` with `timeout` or in a loop if you're feeling | |||
| lazy.) | |||
|
|
|||
| <!-- Needs updated instructions --> | |||
There was a problem hiding this comment.
Needs updated instructions.
There was a problem hiding this comment.
I think this can be deleted.
AlannaBurke
commented
Apr 30, 2025
AlannaBurke
commented
Apr 30, 2025
AlannaBurke
commented
Apr 30, 2025
benchmarks/README.md
Outdated
| @@ -7,6 +7,7 @@ It also provides mechanisms to compare PyTorch with other frameworks. | |||
| ## Setup environment | |||
| Make sure you're on a machine with CUDA, torchvision, and pytorch installed. Install in the following order: | |||
| ``` | |||
| # Do these instructions need to be updated? | |||
There was a problem hiding this comment.
Does this need updated instructions?
AlannaBurke
commented
Apr 30, 2025
AlannaBurke
commented
Apr 30, 2025
AlannaBurke
commented
Apr 30, 2025
svekars
reviewed
May 1, 2025
svekars
reviewed
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149551
Needs input on some of the instructions.
cc @svekars @sekyondaMeta