8000 Use std::apply for CPU code by cyyever · Pull Request #152526 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Use std::apply for CPU code #152526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use std::apply for CPU code #152526

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator
@cyyever cyyever commented Apr 30, 2025 •
edited
Loading

The supported compilers are recent enough to enable std::apply in C++17.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 30, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152526

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 368ef48 with merge base 909ec49 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Apr 30, 2025
@cyyever
Copy link
Collaborator Author
cyyever commented Apr 30, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 30, 2025
@cyyever cyyever force-pushed the std_apply branch 2 times, most recently from 8000 32bd3f9 to a66409a Compare April 30, 2025 10:06
Skylion007
Skylion007 reviewed Apr 30, 2025
View reviewed changes
@cyyever cyyever requested review from eqy and syed-ahmed as code owners April 30, 2025 13:25
@cyyever cyyever force-pushed the std_apply branch 2 times, most recently from 7fb8f32 to dbc9010 Compare April 30, 2025 14:10
@HDCharles HDCharles added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 2, 2025
@cyyever
Copy link
Collaborator Author
cyyever commented May 11, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased std_apply onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout std_apply && git pull --rebase)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@eqy eqy Awaiting requested review from eqy

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed

Assignees
No one assigned
Labels
module: cpu CPU specific problem (e.g., perf, algorithm) open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cyyever @pytorchmergebot @Skylion007 @pytorchbot @HDCharles
0