add device generalisation support for distributed tests #152471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152471
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
etaf
reviewed
May 1, 2025
b3e51b4 to
c640bda
Compare
|
@albanD , @wconstab , @EikanWang , @cyyever , @guangyey : Could you help in reviewing and merging this one ? |
d4l3k
approved these changes
May 12, 2025
| os.remove(self.file_name) | ||
| except OSError: | ||
| pass | ||
|
|
||
| @property | ||
| def world_size(self) -> int: | ||
| return torch.cuda.device_count() |
There was a problem hiding this comment.
does this need to change as well?
|
|
||
| class TestZeroRedundancyOptimizerSingleRank(TestZeroRedundancyOptimizer): | ||
| def test_state_dict(self): | ||
| """Check that ZeroRedundancyOptimizer exposes the expected state dict | ||
| interface, irrespective of the sharding.""" | ||
| self.dist_init(self.rank) | ||
| self.create_pg(self.device) |
There was a problem hiding this comment.
Do we need to pass device here? Seems like we can infer it from the setting on the class since it's on self
| @@ -20,6 +19,7 @@ | |||
| if not dist.is_available(): | |||
| print("Distributed not available, skipping tests", file=sys.stderr) | |||
| sys.exit(0) | |||
| from torch._inductor.utils import is_gpu | |||
There was a problem hiding this comment.
Is it fine for us to depend on inductor code?
There was a problem hiding this comment.
I think it is a bit weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOTIVATION
To generalize Distributed test cases for non-CUDA devices
CHANGES
Replaced hard coded device names with get_devtype from torch.testing._internal.common_fsdp.
DistributedTestBase is used instead of MultiProcessTestCase, to make use of helper functions.
extended common utility functions
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k