8000 Return ConstantVariable(None) from WithExitFunctionVariable.exit to prevent NoneType crash inside autocast exception path by wdziurdz · Pull Request #152013 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Return ConstantVariable(None) from WithExitFunctionVariable.exit to prevent NoneType crash inside autocast exception path #152013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Return ConstantVariable(None) from WithExitFunctionVariable.exit to prevent NoneType crash inside autocast exception path #152013

wants to merge 0 commits into from

Conversation

wdziurdz
Copy link
Contributor
@wdziurdz wdziurdz commented Apr 23, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152013

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 42 Pending

As of commit 0a4b8a0 with merge base 797768c (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wdziurdz
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 23, 2025
@colesbury colesbury requested a review from jansel April 23, 2025 18:29
@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 23, 2025
@jansel
Copy link
Contributor
jansel commented Apr 24, 2025

Add a test?

@wdziurdz
Copy link
Contributor Author

Add a test?

done

@jansel
Copy link
Contributor
jansel commented Apr 28, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 28, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here
< 8000 include-fragment loading="lazy" src="/pytorch/pytorch/issue_comments/2836105602/edit_form?textarea_id=issuecomment-2836105602-body&comment_context=" data-nonce="v2:bec73e60-2b19-6faa-09ff-383fbda8e779" data-view-component="true" class="previewable-comment-form js-comment-edit-form-deferred-include-fragment">

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@jansel
Copy link
Contributor
jansel commented Apr 28, 2025

@wdziurdz can you fix this lints?

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Apr 29, 2025
@wdziurdz
Copy link
Contributor Author

@wdziurdz can you fix this lints?

done

@jansel
Copy link
Contributor
jansel commented Apr 29, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 29, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@jansel
Copy link
Contributor
jansel commented Apr 29, 2025

@pytorchbot rebase

to see if that if that fixes docker issue in CI

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased main onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout main && git pull --rebase)

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Apr 29, 2025
@jansel
Copy link
Contributor
jansel commented Apr 29, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 29, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@jansel jansel closed this Apr 30, 2025
@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Apr 30, 2025
@jansel jansel mentioned this pull request Apr 30, 2025
Closed
@jansel
Copy link
Contributor
jansel commented Apr 30, 2025

Whoops sorry @wdziurdz I tried to update the expected results for you to fixed the unrelated CI issue, but I pushed the wrong ref and it closed the PR. Now it won't let me update your branch that the PR is closed.

I put up a copy with the fix here in #152503

pytorchmergebot pushed a commit that referenced this pull request May 1, 2025
@jansel @wdziurdz @pytorchmergebot
Return ConstantVariable(None) from WithExitFunctionVariable.exit to p…
15a3f58 
…revent NoneType crash inside autocast exception path (#152503)

Copy of #152013 with PR time benchmarks updated (regressions seem unrelated)

Pull Request resolved: #152503
Approved by: https://github.com/anijain2305, https://github.com/Skylion007

Co-authored-by: Witold Dziurdz <wdziurdz@habana.ai>
@wdziurdz wdziurdz mentioned this pull request May 6, 2025
Closed
wdziurdz added a commit to wdziurdz/pytorch that referenced this pull request May 15, 2025
@jansel @wdziurdz
Return ConstantVariable(None) from WithExitFunctionVariable.exit to p…
288a124 
…revent NoneType crash inside autocast exception path (pytorch#152503)

Copy of pytorch#152013 with PR time benchmarks updated (regressions seem unrelated)

Pull Request resolved: pytorch#152503
Approved by: https://github.com/anijain2305, https://github.com/Skylion007

Co-authored-by: Witold Dziurdz <wdziurdz@habana.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansel jansel jansel approved these changes

Assignees
No one assigned
Labels
module: dynamo open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
5 participants
@wdziurdz @jansel @pytorchmergebot @colesbury @pytorchbot
0