8000 [ROCm][CI] Update dockerfile to use centos9 by ethanwee1 · Pull Request #151929 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[ROCm][CI] Update dockerfile to use centos9 #151929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 36 commits into from
Closed

[ROCm][CI] Update dockerfile to use centos9 #151929

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
39927c3
Update dockerfile to use centos9
ethanwee1 Apr 22, 2025
1e74ce1
Port changes from https://github.com/ROCm/pytorch/pull/2044
ethanwee1 Apr 28, 2025
ccf6beb
update docker-builds.yml to include a centos9 build
ethanwee1 May 1, 2025
bc5c5a5
Add centos9 build job
ethanwee1 May 6, 2025
29d8010
bring back amdsmi
ethanwee1 May 8, 2025
5755937
Add in centos
ethanwee1 May 12, 2025
82711d3
Update install_base.sh
ethanwee1 May 13, 2025
b490944
removing CONDA_CMAKE
ethanwee1 May 13, 2025
d727ae8
update to rocm6.4
ethanwee1 May 13, 2025
e83216b
Remove centos-only packages from common list
jithunnair-amd May 14, 2025
48d0d8c
Add ALLOW_ERASE
jithunnair-amd May 15, 2025
540a054
Adding needed changes
ethanwee1 May 15, 2025
0093904
lint
ethanwee1 May 15, 2025
0d3e5a3
Merge branch 'main' into rocm_dockerfile
jithunnair-amd May 15, 2025
d5e3764
Fix syntax and pare down rocm package list to minimal needed
jithunnair-amd May 16, 2025
f53dde6
Fix logic that refers to obsolete AMDGPU_VERSION
jithunnair-a 8000 md May 18, 2025
52088d2
Correct rocm_repo_url for CentOS Stream 9
jithunnair-amd May 18, 2025
07ab240
Consolidate .ci/docker/build.sh cases for ROCm
jithunnair-amd May 19, 2025
0517937
Remove support for CentOS versions older than CentOS Stream 9
jithunnair-amd May 19, 2025
ba3688a
space lint
jithunnair-amd May 19, 2025
3463968
Cleanup old ROCm version cruft
jithunnair-amd May 19, 2025
63c63b3
Remove CentOS7-related code since it's EOL
jithunnair-amd May 19, 2025
dd6c591
Space lint
jithunnair-amd May 19, 2025
79dc6ec
Remove unneeded OS_VERSION variable
jithunnair-amd May 19, 2025
602024c
Install gpg-agent for all Ubuntu versions
jithunnair-amd May 19, 2025
4def3b0
Use dnf, remove CentOS7-related code and hence unneeded OS_VERSION
jithunnair-amd May 19, 2025
e4aa433
Update dnf cleanup commands
jithunnair-amd May 19, 2025
b341fbb
Update dnf cleanup commands
jithunnair-amd May 19, 2025
e08cd48
Update for centos9
ethanwee1 May 20, 2025
3c4c9bc
Add in condition to check if ubuntu or centos
ethanwee1 May 20, 2025
54a502a
Conditionalize whether ubuntu or centos
ethanwee1 May 20, 2025
5b39255
Add an install step for katex
ethanwee1 May 27, 2025
61ad5b9
Add katex arg
ethanwee1 May 27, 2025
c5a8b99
Lint
ethanwee1 May 27, 2025
b9b38d9
Lint
jithunnair-amd May 28, 2025
895466c
addressing comments
ethanwee1 Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update dockerfile to use centos9
  • Loading branch information
@ethanwee1
ethanwee1 committed May 12, 2025
commit 39927c31fefe67faef465172de5ac9c1a142a8b9
25 changes: 13 additions & 12 deletions .ci/docker/centos-rocm/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@

ARG CENTOS_VERSION

FROM centos:${CENTOS_VERSION}
FROM quay.io/centos/centos:stream${CENTOS_VERSION}

ARG CENTOS_VERSION

# Set AMD gpu targets to build for
ARG PYTORCH_ROCM_ARCH
Expand All @@ -11,23 +11,25 @@ ENV PYTORCH_ROCM_ARCH ${PYTORCH_ROCM_ARCH}
# Install required packages to build Caffe2

# Install common dependencies (so that this step can be cached separately)
ARG EC2
COPY ./common/install_base.sh install_base.sh
RUN bash ./install_base.sh && rm install_base.sh

#Install langpack
RUN yum install -y glibc-langpack-en

# Update CentOS git version
RUN yum -y remove git
RUN yum -y remove git-*
RUN yum -y install https://packages.endpoint.com/rhel/7/os/x86_64/endpoint-repo-1.9-1.x86_64.rpm || \
(yum -y install https://packages.endpointdev.com/rhel/7/os/x86_64/endpoint-repo-1.9-1.x86_64.rpm && \
sed -i "s/packages.endpoint/packages.endpointdev/" /etc/yum.repos.d/endpoint.repo)
RUN yum install -y git

# Install devtoolset
ARG DEVTOOLSET_VERSION
COPY ./common/install_devtoolset.sh install_devtoolset.sh
RUN bash ./install_devtoolset.sh && rm install_devtoolset.sh
RUN dnf install -y rpmdevtools
ENV BASH_ENV "/etc/profile"

# Install ninja
RUN dnf --enablerepo=crb install -y ninja-build

# (optional) Install non-default glibc version
ARG GLIBC_VERSION
COPY ./common/install_glibc.sh install_glibc.sh
Expand Down Expand Up @@ -60,11 +62,10 @@ COPY ./common/install_rocm.sh install_rocm.sh
RUN bash ./install_rocm.sh
RUN rm install_rocm.sh
COPY ./common/install_rocm_magma.sh install_rocm_magma.sh
RUN bash ./install_rocm_magma.sh ${ROCM_VERSION}
RUN bash ./install_rocm_magma.sh
RUN rm install_rocm_magma.sh
COPY ./common/install_amdsmi.sh install_amdsmi.sh
RUN bash ./install_amdsmi.sh
RUN rm install_amdsmi.sh

ENV ROCM_PATH /opt/rocm
ENV PATH /opt/rocm/bin:$PATH
ENV PATH /opt/rocm/hcc/bin:$PATH
ENV PATH /opt/rocm/hip/bin:$PATH
Expand Down
0